Disallow key duplicates

[darosior]

No description provided.

[stickies-v]

Which key duplicates are we talking about? Node properties, cryptographic keys, or something else?

[darosior]

I meant the secp256k1 public keys. The problem is that if a signature is given for a key, but that is repeated through the Miniscript it becomes really hard to reason about malleability. ~~See the linked issue for more details.~~

…

-------- Original Message --------

On May 1, 2022, 8:17 PM, stickies-v wrote: Which key duplicates are we talking about? Node properties, cryptographic keys, or something else? — Reply to this email directly, [view it on GitHub](#12 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F6WX7AXOCEXUV5K3RTVH3DFJANCNFSM5UEWMZTQ). You are receiving this because you authored the thread.Message ID: ***@***.***>

[darosior]

It should be trivial to check for now that we have the keys property of descriptors:

python-bip380/bip380/descriptors/__init__.py

Lines 38 to 42 in 8aa1e2f

	@property
	def keys(self):
	"""Get the list of all keys from this descriptor, in order of apparition."""
	# To be implemented by derived classes
	raise NotImplementedError

[SomberNight]

See the linked issue for more details

Where is the link?

[darosior]

🤦 thanks for pointing that out @SomberNight. There was no link, and i don't remember what i was referring to now.

We introduced this change in the C++ implementation in sipa/miniscript#116.