Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Commit

Permalink
Merge branch 'master' into fix/async_cache_storing_exception
Browse files Browse the repository at this point in the history
  • Loading branch information
akmalviya03 authored Jun 26, 2024
2 parents de2067d + d7c0cd5 commit 67b8250
Show file tree
Hide file tree
Showing 10 changed files with 24 additions and 24 deletions.
4 changes: 4 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@ updates:
interval: monthly
labels:
- autosubmit
groups:
github-actions:
patterns:
- "*"
13 changes: 6 additions & 7 deletions .github/workflows/test-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
matrix:
sdk: [dev]
steps:
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633
- uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29
- uses: dart-lang/setup-dart@f0ead981b4d9a35b37f30d36160575d60931ec30
with:
sdk: ${{ matrix.sdk }}
- id: install
Expand All @@ -47,10 +47,10 @@ jobs:
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
os: [ubuntu-latest]
sdk: [3.2, dev]
sdk: [3.4, dev]
steps:
- uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633
- uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29
- uses: dart-lang/setup-dart@f0ead981b4d9a35b37f30d36160575d60931ec30
with:
sdk: ${{ matrix.sdk }}
- id: install
Expand All @@ -62,5 +62,4 @@ jobs:
- run: dart test --platform chrome --compiler dart2js
if: always() && steps.install.outcome == 'success'
- run: dart test --platform chrome --compiler dart2wasm
# TODO: drop `dev` filter when dart2wasm is working on stable
if: always() && steps.install.outcome == 'success' && matrix.sdk == 'dev'
if: always() && steps.install.outcome == 'success'
4 changes: 1 addition & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
## 2.12.0-wip

* Require Dart 3.2
* Can decide `fetch` method of `AsyncCache` will store exception or not.

* Require Dart 3.2

## 2.11.0

Expand Down
2 changes: 1 addition & 1 deletion lib/async.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/// library.
///
/// {@youtube 560 315 https://www.youtube.com/watch?v=r0tHiCjW2w0}
library async;
library;

export 'src/async_cache.dart';
export 'src/async_memoizer.dart';
Expand Down
4 changes: 1 addition & 3 deletions lib/src/cancelable_operation.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

import 'dart:async';

import 'package:collection/collection.dart';

/// An asynchronous operation that can be cancelled.
///
/// The value of this operation is exposed as [value]. When this operation is
Expand Down Expand Up @@ -521,7 +519,7 @@ class CancelableCompleter<T> {
final isFuture = toReturn is Future;
final cancelFutures = <Future<Object?>>[
if (isFuture) toReturn,
...?_cancelForwarders?.map(_forward).whereNotNull()
...?_cancelForwarders?.map(_forward).nonNulls
];
final results = (isFuture && cancelFutures.length == 1)
? [await toReturn]
Expand Down
4 changes: 1 addition & 3 deletions lib/src/stream_group.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

import 'dart:async';

import 'package:collection/collection.dart';

/// A collection of streams whose events are unified and sent through a central
/// stream.
///
Expand Down Expand Up @@ -239,7 +237,7 @@ class StreamGroup<T> implements Sink<Stream<T>> {
return null;
}
})
.whereNotNull()
.nonNulls
.toList();

_subscriptions.clear();
Expand Down
2 changes: 1 addition & 1 deletion lib/src/stream_queue.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import 'dart:async';
import 'dart:collection';

import 'package:collection/collection.dart';
import 'package:collection/collection.dart' show QueueList;

import 'cancelable_operation.dart';
import 'result/result.dart';
Expand Down
11 changes: 7 additions & 4 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,17 @@ description: Utility functions and classes related to the 'dart:async' library.
repository: https://github.com/dart-lang/async

environment:
sdk: ^3.2.0
sdk: ^3.4.0

dependencies:
collection: ^1.15.0
meta: ^1.1.7
meta: ^1.3.0

dev_dependencies:
dart_flutter_team_lints: ^2.0.0
dart_flutter_team_lints: ^3.0.0
fake_async: ^1.2.0
stack_trace: ^1.10.0
test: ^1.16.0
test: ^1.16.6

topics:
- async
2 changes: 1 addition & 1 deletion test/io_sink_impl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@Deprecated('Tests deprecated functionality')
library io_sink_impl;
library;

import 'dart:io';

Expand Down
2 changes: 1 addition & 1 deletion test/sink_base_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.

@Deprecated('Tests deprecated functionality')
library sink_base_test;
library;

import 'dart:async';
import 'dart:convert';
Expand Down

0 comments on commit 67b8250

Please # to comment.