This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Fixes a bug in the CSS string escape handling. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS parser would interpret escapes in identifiers in strings. This caused the strings to be incorrectly parsed. This renames _skipWhitespace to be _inString (as it is only used in string parsing) and extends it to disable the escape handling in identifiers.
|
LGTM, Thanks! |
|
would you mind adding a line in the CHANGELOG and changing the pubspec version to 0.12.1? Then I can push a new release to pub |
|
I'm not really familiar with the formats, let me know if I screwed anything up. |
|
all looks great. thanks again! |
sigmundch
added a commit
that referenced
this pull request
Jul 10, 2015
Fixes a bug in the CSS string escape handling.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
Fixes a bug in the CSS string escape handling.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS parser would interpret escapes in identifiers in strings. This
caused the strings to be incorrectly parsed. This renames
_skipWhitespace to be _inString (as it is only used in string parsing)
and extends it to disable the escape handling in identifiers.