Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Fixes a bug in the CSS string escape handling. #12

Merged
merged 2 commits into from
Jul 10, 2015

Conversation

winstonewert
Copy link
Contributor

The CSS parser would interpret escapes in identifiers in strings. This
caused the strings to be incorrectly parsed. This renames
_skipWhitespace to be _inString (as it is only used in string parsing)
and extends it to disable the escape handling in identifiers.

The CSS parser would interpret escapes in identifiers in strings. This
caused the strings to be incorrectly parsed. This renames
_skipWhitespace to be _inString (as it is only used in string parsing)
and extends it to disable the escape handling in identifiers.
@sigmundch
Copy link
Contributor

LGTM, Thanks!

@sigmundch
Copy link
Contributor

would you mind adding a line in the CHANGELOG and changing the pubspec version to 0.12.1? Then I can push a new release to pub

@winstonewert
Copy link
Contributor Author

I'm not really familiar with the formats, let me know if I screwed anything up.

@sigmundch
Copy link
Contributor

all looks great. thanks again!

sigmundch added a commit that referenced this pull request Jul 10, 2015
Fixes a bug in the CSS string escape handling.
@sigmundch sigmundch merged commit 541b168 into dart-archive:master Jul 10, 2015
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
Fixes a bug in the CSS string escape handling.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants