This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
fix strong mode errors, and a bunch of analyzer messages #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R= @sigmundch if you don't mind taking a look :) |
| @@ -278,10 +278,11 @@ class Color implements _StyleProperty, ColorBase { | |||
| return new Hsla(args[0], args[1], args[2], args[3]).toHexArgbString(); | |||
| default: | |||
| // Type not defined UnsupportedOperationException should have thrown. | |||
| assert(true); | |||
| assert(false); | |||
There was a problem hiding this comment.
does ddc check for this? or was this an analyzer hint?
There was a problem hiding this comment.
Ah, neither ... there is a message about missing return, and the John Analyzer noticed it :)
|
BTW, I'm happy to "git cl upload" if you want? I just noticed this project does have a .settings file for that. |
|
LGTM, yeah sorry, I was ooo yesterday. if it starts getting bigger git-cl sounds good, otherwise I'm fine with prs |
jmesserly
pushed a commit
that referenced
this pull request
Sep 24, 2015
fix strong mode errors, and a bunch of analyzer messages
|
Thanks!!! |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
fix strong mode errors, and a bunch of analyzer messages
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't get to all of the warnings (about 50).