Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Update processFont to handle null expressions. #186

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

ykmnkmi
Copy link
Contributor

@ykmnkmi ykmnkmi commented Jun 18, 2023

CSS

.foo {
  color:;
}
.bar {
  font:;
  color: blue;
}

StackTrace:

Null check operator used on a null value
package:csslib/parser.dart 2855:23               ExpressionsProcessor.processFont
package:csslib/parser.dart 1912:43               _Parser.buildDartStyleNode
package:csslib/parser.dart 1884:14               _Parser._styleForDart
package:csslib/parser.dart 1762:27               _Parser.processDeclaration
package:csslib/parser.dart 1178:18               _Parser.processDeclarations
package:csslib/parser.dart 1095:37               _Parser.processRule
package:csslib/parser.dart 205:20                _Parser.parse
package:csslib/parser.dart 65:36                 compile

@devoncarew
Copy link
Contributor

Thanks for the contribution! As per our contribution guidelines (https://github.com/dart-lang/.github/blob/main/PULL_REQUEST_TEMPLATE.md?plain=1), can you:

  • add test(s) for this change?
  • update the pubspec version to the next logical version (for this case, likely 1.0.1-wip)
  • add a new entry to the changelog

Thanks!

Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@devoncarew devoncarew merged commit b58e487 into dart-archive:main Mar 19, 2024
8 checks passed
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
* Update processFont to handle null expressions.

* Guidelines.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants