This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Import dart:io directly #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @keertip |
goderbauer
reviewed
Mar 20, 2018
| `dart:io` to be imported in a browser context, though if methods are actually | ||
| invoked, they will fail. This matches well with `package:file`, where users | ||
| can use the `memory` library and get in-memory implementations of the | ||
| `dart:io` interfaces. |
There was a problem hiding this comment.
nit: maybe mention in a extra bullet that the minimum SDK has been bumped to 1.24?
|
Thanks! |
yjbanov
reviewed
Mar 20, 2018
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: file | |||
| version: 2.3.7 | |||
| version: 2.4.0 | |||
There was a problem hiding this comment.
Seems like a pretty major breaking change. Maybe start 3.0.0?
There was a problem hiding this comment.
For users past SDK 1.24, it's actually not breaking at all, but I'm happy to bump it to 3.0.0 regardless. Done!
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.