Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

fix super.key false positive for use_key_in_widget_constructors #3295

Merged
merged 2 commits into from
Mar 17, 2022
Merged

fix super.key false positive for use_key_in_widget_constructors #3295

merged 2 commits into from
Mar 17, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented Mar 17, 2022 •
edited
Loading

See: flutter/flutter#100297.

(Note that we don't have Flutter mocked for our rule tests so I resorted to "old-school" testing.)

/cc @bwilkerson

@pq pq mentioned this pull request Mar 17, 2022
Closed
@coveralls
Copy link

coveralls commented Mar 17, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 95.691% when pulling 0702af6 on use_super_parameters_key_fp into 7f03036 on master.

@goderbauer goderbauer mentioned this pull request Mar 17, 2022
Merged
bwilkerson
bwilkerson approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as-is, just one random thought.

@pq pq merged commit 6b4538c into master Mar 17, 2022
@pq pq deleted the use_super_parameters_key_fp branch March 17, 2022 17:23
@pq pq mentioned this pull request Mar 29, 2022
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
fix super.key false positive for use_key_in_widget_constructors (da…
a0bc891 
…rt-archive/linter#3295)

* fix super.key false positive for `use_key_in_widget_constructors`

* - type test
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pq @coveralls @bwilkerson