This repository was archived by the owner on Feb 22, 2018. It is now read-only.
feat(const): Translate CONST_EXPR to const expressions. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to construct compile time literal (const) expressions in Dart, e.g.
const bools = CONST_EXPR([true, false, FileNotFound]);
|
Allows progress on angular/angular#1524. |
|
@mprobst awesome. Shell we have the |
|
@pkozlowski-opensource yes, the idea is that the TS code would have a global function in Actually let me make sure we'll filter a |
Remove both the annotations and the corresponding imports.
|
This also fixes #13 now. |
|
+1! |
|
@alexeagle I'm off for the day, please merge & release if you think this is fine, or take over the change if you think it isn't. |
|
Looks great, merging now. |
alexeagle
added a commit
that referenced
this pull request
May 8, 2015
feat(const): Translate CONST_EXPR to const expressions.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to construct compile time literal (const) expressions in Dart, e.g.