Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: support dynamic method name for member-ordering #1044

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

#956

@incendial incendial added type: enhancement New feature or request area-rules labels Oct 19, 2022
@incendial incendial added this to the 5.0.0 milestone Oct 19, 2022
@incendial incendial requested a review from dkrutskikh October 19, 2022 14:59
@incendial incendial self-assigned this Oct 19, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 515

  • Total lines of source code: 8882

  • Total classes: 388

  • Average Cyclomatic Number per line of code: 0.37 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1718.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1044 (6aebc29) into master (371f598) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
- Coverage   86.51%   86.46%   -0.06%     
==========================================
  Files         326      326              
  Lines        6958     6929      -29     
==========================================
- Hits         6020     5991      -29     
  Misses        938      938              
Impacted Files Coverage Δ
...ules/rules_list/member_ordering/config_parser.dart 100.00% <100.00%> (ø)
...ules_list/member_ordering/models/member_group.dart 93.75% <100.00%> (-0.76%) ⬇️
...yzer/rules/rules_list/member_ordering/visitor.dart 96.82% <100.00%> (-0.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 1b6a848 into master Oct 19, 2022
@incendial incendial deleted the support-dynamic-method-name-for-order branch October 19, 2022 15:26
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant