Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: change severity for avoid-banned-imports, prefer-trailing-comma, ban-name rules #1052

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

incendial
Copy link
Member

@incendial incendial commented Oct 23, 2022

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added this to the 5.0.0 milestone Oct 23, 2022
@incendial incendial self-assigned this Oct 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 515

  • Total lines of source code: 8887

  • Total classes: 388

  • Average Cyclomatic Number per line of code: 0.37 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1718.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #1052 (ccc777f) into master (0f646c4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1052   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files         326      326           
  Lines        6933     6933           
=======================================
  Hits         5995     5995           
  Misses        938      938           
Impacted Files Coverage Δ
...lyzer/rules/rules_list/tag_name/tag_name_rule.dart 100.00% <ø> (ø)
...void_banned_imports/avoid_banned_imports_rule.dart 100.00% <100.00%> (ø)
...lyzer/rules/rules_list/ban_name/ban_name_rule.dart 100.00% <100.00%> (ø)
...fer_trailing_comma/prefer_trailing_comma_rule.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 6f4985d into master Oct 23, 2022
@incendial incendial deleted the revisit-rules-severity branch October 23, 2022 17:33
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants