Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add metric value unit type #580

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #580 (0173cf8) into master (2d324e8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 0173cf8 differs from pull request most recent head 24dba48. Consider uploading reports for the commit 24dba48 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   85.76%   85.79%   +0.03%     
==========================================
  Files         227      227              
  Lines        4720     4731      +11     
==========================================
+ Hits         4048     4059      +11     
  Misses        672      672              
Impacted Files Coverage Δ
...ers/lint_analyzer/metrics/models/metric_value.dart 100.00% <ø> (ø)
...zer/metrics/metrics_list/lines_of_code_metric.dart 100.00% <100.00%> (ø)
...metrics/metrics_list/number_of_methods_metric.dart 100.00% <100.00%> (ø)
...rce_lines_of_code/source_lines_of_code_metric.dart 100.00% <100.00%> (ø)
...analyzers/lint_analyzer/metrics/models/metric.dart 100.00% <100.00%> (ø)
...ers_list/console/lint_console_reporter_helper.dart 88.88% <100.00%> (ø)
...s_list/html/components/report_details_tooltip.dart 100.00% <100.00%> (ø)
...orters/reporters_list/json/lint_json_reporter.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d324e8...24dba48. Read the comment docs.

@dkrutskikh dkrutskikh force-pushed the metric-value-unit-type branch from 5ecbfd2 to 24dba48 Compare December 1, 2021 14:53
@dkrutskikh dkrutskikh merged commit 411c51b into master Dec 1, 2021
@dkrutskikh dkrutskikh deleted the metric-value-unit-type branch December 1, 2021 16:03
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants