run analyzer on benchmark package, add it to workspace (#3820)

* run analyzer on benchmark package, add it to workspace * use the 3.6.0 sdk
dart-lang · Feb 4, 2025 · 4e5a83c · 4e5a83c
1 parent 5c1ddd4
commit 4e5a83c
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 6 deletions.
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
diff --git a/_benchmark/lib/commands.dart b/_benchmark/lib/commands.dart
@@ -33,7 +33,7 @@ class CreateCommand extends Command<void> {
   Future<void> run() => _run(globalResults!);
 
   Future<void> _run(ArgResults globalResults) async {
-    final config = Config.fromArgResults(globalResults!);
+    final config = Config.fromArgResults(globalResults);
 
     for (final size in config.sizes) {
       final paddedSize = size.toString().padLeft(4, '0');
@@ -64,7 +64,7 @@ class MeasureCommand extends Command<void> {
 
   Future<void> _run(ArgResults globalResults) async {
     // Launch a benchmark at each size in parallel.
-    final config = Config.fromArgResults(globalResults!);
+    final config = Config.fromArgResults(globalResults);
     final pendingResults = <int, PendingResult>{};
     for (final size in config.sizes) {
       final paddedSize = size.toString().padLeft(4, '0');

diff --git a/_benchmark/mono_pkg.yaml b/_benchmark/mono_pkg.yaml
@@ -0,0 +1,9 @@
+sdk:
+- pubspec
+
+os:
+- linux
+
+stages:
+- analyze_and_format:
+  - analyze: --fatal-infos .
diff --git a/_benchmark/pubspec.yaml b/_benchmark/pubspec.yaml
@@ -1,7 +1,8 @@
 name: _benchmark
 publish_to: none
 environment:
-  sdk: ^3.7.0-edge
+  sdk: ^3.6.0
+resolution: workspace
 
 dependencies:
   args: ^2.6.0

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -6,6 +6,7 @@ dev_dependencies:
   dart_flutter_team_lints: ^3.1.0
 
 workspace:
+- _benchmark
 - _test
 - _test/pkgs/provides_builder
 - _test_common