-
Notifications
You must be signed in to change notification settings - Fork 579
Update README.md for local dev instructions #371
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@googlebot I signed it! |
@@ -23,6 +23,19 @@ work in progress. | |||
Please file reports on the | |||
[GitHub Issue Tracker](https://github.com/dart-lang/dart-pad/issues). | |||
|
|||
## Running locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessary to run the front-end; you can launch web/index.html (the desktop version) or web/mobile.html (the mobile version) directly from the editor.
I think these instructions may confuse people a bit. Perhaps add a disclaimer that the front-end can be run w/o any server, but if you want to test the auto-redirect, here are some steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, sg, will do.
lgtm w/ comments Please make yourself right with @googlebot |
Thanks @devoncarew . Issues with @googlebot seem to be related to using GitHub's UI for modification, I'll route things through a local change in future. |
still relevant? |
@devoncarew Lets chat about this in a couple of weeks and review. I still have a bunch of problems with my local build setup seemingly. |
@devoncarew PTAL - I'm not sure the way I'm suggesting people use grind is correct, I've had some problems running the travis script locally. Could you correct as appropriate?