Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

issues rolling into google3 (from the sdk) #3969

Closed
devoncarew opened this issue Jan 22, 2025 · 5 comments
Closed

issues rolling into google3 (from the sdk) #3969

devoncarew opened this issue Jan 22, 2025 · 5 comments
Assignees
@srawlins
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@devoncarew
Copy link
Member

I'm seeing issues rolling the recent ~6 commits into google3:

.../dartdoc/bin/main.dart:15:24: Error: The argument type 'PackageMeta? Function(LibraryElement, String?, ResourceProvider)' can't be assigned to the parameter type 'PackageMeta? Function(LibraryElement2, String, ResourceProvider)'.
 - 'PackageMeta' is from 'package:dartdoc/src/package_meta.dart' ('.../dart/dartdoc/lib/src/package_meta.dart').
 - 'LibraryElement' is from 'package:analyzer/dart/element/element.dart' ('.../dart/analyzer/lib/dart/element/element.dart').
 - 'ResourceProvider' is from 'package:analyzer/file_system/file_system.dart' ('.../dart/analyzer/lib/file_system/file_system.dart').
 - 'LibraryElement2' is from 'package:analyzer/dart/element/element2.dart' ('.../dart/analyzer/lib/dart/element/element2.dart').
    Google3PackageMeta.fromElement,
                       ^


ERROR: dart/dartdoc/bin/main.dart:15
The argument type 'PackageMeta? Function(LibraryElement, String?, ResourceProvider)' can't be assigned to the parameter type 'PackageMeta? Function(LibraryElement2, String, ResourceProvider)'. #argument_type_not_assignable

    Google3PackageMeta.fromElement,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@srawlins
Copy link
Member

That roll will require a patch at dart/dartdoc/bin/main.dart:15.

@pq pq added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Jan 29, 2025
@pq
Copy link
Member

pq commented Jan 29, 2025

Is this issue resolved?

@devoncarew
Copy link
Member Author

I don't believe so - I have not rolled it in since filing this.

@srawlins
Copy link
Member

I'm looking at this now.

@srawlins srawlins self-assigned this Feb 14, 2025
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 18, 2025
@srawlins
Bump dartdoc to 56934b7d567d1301ae6ad79aed9fc6f3e9fd15e3
78eedc4 
Fixes dart-lang/dartdoc#3969

A patch is attached for internal preparation.

Change-Id: I750ea3b488a0fd241087b543ac520cb17349d7fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410162
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
@srawlins
Copy link
Member

Fixed with https://dart-review.googlesource.com/c/sdk/+/410162

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@srawlins srawlins

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @srawlins @devoncarew