improve pub score (dart-archive/web_socket_channel#33)

Update analyzer and clean up warnings

Author: felangel

pkgs/web_socket_channel/.travis.yml

@@ -5,7 +5,7 @@ dart: dev
 dart_task:
   - test: --platform vm
   - test: --platform firefox -j 1
-  - dartanalyzer
+  - dartanalyzer --fatal-infos --fatal-warnings
 
 matrix:
   include:
@@ -17,5 +17,5 @@ branches:
   only: [master]
 
 cache:
- directories:
-   - $HOME/.pub-cache
+  directories:
+    - $HOME/.pub-cache

pkgs/web_socket_channel/CONTRIBUTING.md

@@ -23,7 +23,7 @@ All submissions, including submissions by project members, require review.
 ### File headers
 All files in the project must start with the following header.
 
-    // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
+    // Copyright (c) 2018, the Dart project authors.  Please see the AUTHORS file
     // for details. All rights reserved. Use of this source code is governed by a
     // BSD-style license that can be found in the LICENSE file.
 

pkgs/web_socket_channel/README.md

@@ -56,7 +56,7 @@ other socket exactly why they're closing the connection.
 
 `WebSocketChannel` also works as a cross-platform implementation of the
 WebSocket protocol. Because it can't initiate or handle HTTP requests in a
-cross-platform way, the [`new WebSocketChannel()` constructor][new] takes an
+cross-platform way, the [`WebSocketChannel()` constructor][new] takes an
 underlying [`StreamChannel`][stream_channel] over which it communicates using
 the WebSocket protocol. It also provides the static [`signKey()`][signKey]
 method to make it easier to implement the [initial WebSocket handshake][]. These
@@ -78,18 +78,18 @@ has its own library, `package:web_socket_channel/io.dart`. This allows the main
 [io.WebSocket]: https://api.dartlang.org/latest/dart-io/WebSocket-class.html
 
 An `IOWebSocketChannel` can be created by passing a `dart:io` WebSocket to
-[its constructor][new IOWebSocketChannel]. It's more common to want to connect
+[its constructor][IOWebSocketChannel]. It's more common to want to connect
 directly to a `ws://` or `wss://` URL, in which case
-[`new IOWebSocketChannel.connect()`][IOWebSocketChannel.connect] should be used.
+[`IOWebSocketChannel.connect()`][IOWebSocketChannel.connect] should be used.
 
-[new IOWebSocketChannel]: https://www.dartdocs.org/documentation/web_socket_channel/latest/io/IOWebSocketChannel/IOWebSocketChannel.html
+[IOWebSocketChannel]: https://www.dartdocs.org/documentation/web_socket_channel/latest/io/IOWebSocketChannel/IOWebSocketChannel.html
 [IOWebSocketChannel.connect]: https://www.dartdocs.org/documentation/web_socket_channel/latest/io/IOWebSocketChannel/IOWebSocketChannel.connect.html
 
 ```dart
 import 'package:web_socket_channel/io.dart';
 
 main() async {
-  var channel = new IOWebSocketChannel.connect("ws://localhost:8181");
+  var channel = IOWebSocketChannel.connect("ws://localhost:8181");
   channel.sink.add("connected!");
   channel.stream.listen((message) {
     // ...
@@ -107,18 +107,18 @@ This allows the main `WebSocketChannel` class to be available on all platforms.
 [html.WebSocket]: https://api.dartlang.org/latest/dart-html/WebSocket-class.html
 
 An `HtmlWebSocketChannel` can be created by passing a `dart:html` WebSocket to
-[its constructor][new HtmlWebSocketChannel]. It's more common to want to connect
+[its constructor][HtmlWebSocketChannel]. It's more common to want to connect
 directly to a `ws://` or `wss://` URL, in which case
-[`new HtmlWebSocketChannel.connect()`][HtmlWebSocketChannel.connect] should be used.
+[`HtmlWebSocketChannel.connect()`][HtmlWebSocketChannel.connect] should be used.
 
-[new HtmlWebSocketChannel]: https://www.dartdocs.org/documentation/web_socket_channel/latest/html/HtmlWebSocketChannel/HtmlWebSocketChannel.html
+[HtmlWebSocketChannel]: https://www.dartdocs.org/documentation/web_socket_channel/latest/html/HtmlWebSocketChannel/HtmlWebSocketChannel.html
 [HtmlWebSocketChannel.connect]: https://www.dartdocs.org/documentation/web_socket_channel/latest/html/HtmlWebSocketChannel/HtmlWebSocketChannel.connect.html
 
 ```dart
 import 'package:web_socket_channel/html.dart';
 
 main() async {
-  var channel = new HtmlWebSocketChannel.connect("ws://localhost:8181");
+  var channel = HtmlWebSocketChannel.connect("ws://localhost:8181");
   channel.sink.add("connected!");
   channel.stream.listen((message) {
     // ...

pkgs/web_socket_channel/example/example.dart

@@ -0,0 +1,15 @@
+// Copyright (c) 2018, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:web_socket_channel/io.dart';
+import 'package:web_socket_channel/status.dart' as status;
+
+void main() async {
+  final channel = await IOWebSocketChannel.connect("ws://localhost:1234");
+
+  channel.stream.listen((message) {
+    channel.sink.add("received!");
+    channel.sink.close(status.goingAway);
+  });
+}

pkgs/web_socket_channel/lib/html.dart

@@ -46,7 +46,7 @@ class HtmlWebSocketChannel extends StreamChannelMixin
 
   Stream get stream => _controller.foreign.stream;
   final _controller =
-      new StreamChannelController(sync: true, allowForeignErrors: false);
+      StreamChannelController(sync: true, allowForeignErrors: false);
 
   WebSocketSink get sink => _sink;
   WebSocketSink _sink;
@@ -64,12 +64,12 @@ class HtmlWebSocketChannel extends StreamChannelMixin
   /// [BinaryType.blob], they're delivered as [Blob]s instead.
   HtmlWebSocketChannel.connect(url,
       {Iterable<String> protocols, BinaryType binaryType})
-      : this(new WebSocket(url.toString(), protocols)
+      : this(WebSocket(url.toString(), protocols)
           ..binaryType = (binaryType ?? BinaryType.list).value);
 
   /// Creates a channel wrapping [webSocket].
   HtmlWebSocketChannel(this._webSocket) {
-    _sink = new _HtmlWebSocketSink(this);
+    _sink = _HtmlWebSocketSink(this);
 
     if (_webSocket.readyState == WebSocket.OPEN) {
       _listen();
@@ -84,8 +84,8 @@ class HtmlWebSocketChannel extends StreamChannelMixin
     // The socket API guarantees that only a single error event will be emitted,
     // and that once it is no open or message events will be emitted.
     _webSocket.onError.first.then((_) {
-      _controller.local.sink.addError(
-          new WebSocketChannelException("WebSocket connection failed."));
+      _controller.local.sink
+          .addError(WebSocketChannelException("WebSocket connection failed."));
       _controller.local.sink.close();
     });
 

pkgs/web_socket_channel/lib/io.dart

@@ -53,25 +53,25 @@ class IOWebSocketChannel extends StreamChannelMixin
       Map<String, dynamic> headers,
       Duration pingInterval}) {
     var channel;
-    var sinkCompleter = new WebSocketSinkCompleter();
+    var sinkCompleter = WebSocketSinkCompleter();
     var stream = StreamCompleter.fromFuture(
         WebSocket.connect(url.toString(), headers: headers).then((webSocket) {
       webSocket.pingInterval = pingInterval;
       channel._webSocket = webSocket;
-      sinkCompleter.setDestinationSink(new _IOWebSocketSink(webSocket));
+      sinkCompleter.setDestinationSink(_IOWebSocketSink(webSocket));
       return webSocket;
-    }).catchError((error) => throw new WebSocketChannelException.from(error)));
+    }).catchError((error) => throw WebSocketChannelException.from(error)));
 
-    channel = new IOWebSocketChannel._withoutSocket(stream, sinkCompleter.sink);
+    channel = IOWebSocketChannel._withoutSocket(stream, sinkCompleter.sink);
     return channel;
   }
 
   /// Creates a channel wrapping [socket].
   IOWebSocketChannel(WebSocket socket)
       : _webSocket = socket,
         stream = socket.handleError(
-            (error) => throw new WebSocketChannelException.from(error)),
-        sink = new _IOWebSocketSink(socket);
+            (error) => throw WebSocketChannelException.from(error)),
+        sink = _IOWebSocketSink(socket);
 
   /// Creates a channel without a socket.
   ///
@@ -80,7 +80,7 @@ class IOWebSocketChannel extends StreamChannelMixin
   IOWebSocketChannel._withoutSocket(Stream stream, this.sink)
       : _webSocket = null,
         stream = stream.handleError(
-            (error) => throw new WebSocketChannelException.from(error));
+            (error) => throw WebSocketChannelException.from(error));
 }
 
 /// A [WebSocketSink] that forwards [close] calls to a `dart:io` [WebSocket].

pkgs/web_socket_channel/lib/src/channel.dart

@@ -47,13 +47,13 @@ class WebSocketChannel extends StreamChannelMixin {
   /// Before the connection has been closed, this will be `null`.
   String get closeReason => _webSocket.closeReason;
 
-  Stream get stream => new StreamView(_webSocket);
+  Stream get stream => StreamView(_webSocket);
 
   /// The sink for sending values to the other endpoint.
   ///
   /// This supports additional arguments to [WebSocketSink.close] that provide
   /// the remote endpoint reasons for closing the connection.
-  WebSocketSink get sink => new WebSocketSink._(_webSocket);
+  WebSocketSink get sink => WebSocketSink._(_webSocket);
 
   /// Signs a `Sec-WebSocket-Key` header sent by a WebSocket client as part of
   /// the [initial handshake][].
@@ -91,7 +91,7 @@ class WebSocketChannel extends StreamChannelMixin {
   /// [WebSocket handshake]: https://tools.ietf.org/html/rfc6455#section-4
   WebSocketChannel(StreamChannel<List<int>> channel,
       {String protocol, Duration pingInterval, bool serverSide: true})
-      : _webSocket = new WebSocketImpl.fromSocket(
+      : _webSocket = WebSocketImpl.fromSocket(
             channel.stream, channel.sink, protocol, serverSide)
           ..pingInterval = pingInterval;
 }

pkgs/web_socket_channel/lib/src/copy/bytes_builder.dart

@@ -26,9 +26,9 @@ abstract class BytesBuilder {
   /// output. Default is `true`.
   factory BytesBuilder({bool copy: true}) {
     if (copy) {
-      return new _CopyingBytesBuilder();
+      return _CopyingBytesBuilder();
     } else {
-      return new _BytesBuilder();
+      return _BytesBuilder();
     }
   }
 
@@ -71,15 +71,15 @@ class _CopyingBytesBuilder implements BytesBuilder {
   // Start with 1024 bytes.
   static const int _INIT_SIZE = 1024;
 
-  static final _emptyList = new Uint8List(0);
+  static final _emptyList = Uint8List(0);
 
   int _length = 0;
   Uint8List _buffer;
 
   _CopyingBytesBuilder([int initialCapacity = 0])
       : _buffer = (initialCapacity <= 0)
             ? _emptyList
-            : new Uint8List(_pow2roundup(initialCapacity));
+            : Uint8List(_pow2roundup(initialCapacity));
 
   void add(List<int> bytes) {
     int bytesLength = bytes.length;
@@ -119,22 +119,21 @@ class _CopyingBytesBuilder implements BytesBuilder {
     } else {
       newSize = _pow2roundup(newSize);
     }
-    var newBuffer = new Uint8List(newSize);
+    var newBuffer = Uint8List(newSize);
     newBuffer.setRange(0, _buffer.length, _buffer);
     _buffer = newBuffer;
   }
 
   List<int> takeBytes() {
     if (_length == 0) return _emptyList;
-    var buffer = new Uint8List.view(_buffer.buffer, 0, _length);
+    var buffer = Uint8List.view(_buffer.buffer, 0, _length);
     clear();
     return buffer;
   }
 
   List<int> toBytes() {
     if (_length == 0) return _emptyList;
-    return new Uint8List.fromList(
-        new Uint8List.view(_buffer.buffer, 0, _length));
+    return Uint8List.fromList(Uint8List.view(_buffer.buffer, 0, _length));
   }
 
   int get length => _length;
@@ -169,14 +168,14 @@ class _BytesBuilder implements BytesBuilder {
     if (bytes is Uint8List) {
       typedBytes = bytes;
     } else {
-      typedBytes = new Uint8List.fromList(bytes);
+      typedBytes = Uint8List.fromList(bytes);
     }
     _chunks.add(typedBytes);
     _length += typedBytes.length;
   }
 
   void addByte(int byte) {
-    _chunks.add(new Uint8List(1)..[0] = byte);
+    _chunks.add(Uint8List(1)..[0] = byte);
     _length++;
   }
 
@@ -187,7 +186,7 @@ class _BytesBuilder implements BytesBuilder {
       clear();
       return buffer;
     }
-    var buffer = new Uint8List(_length);
+    var buffer = Uint8List(_length);
     int offset = 0;
     for (var chunk in _chunks) {
       buffer.setRange(offset, offset + chunk.length, chunk);
@@ -199,7 +198,7 @@ class _BytesBuilder implements BytesBuilder {
 
   List<int> toBytes() {
     if (_length == 0) return _CopyingBytesBuilder._emptyList;
-    var buffer = new Uint8List(_length);
+    var buffer = Uint8List(_length);
     int offset = 0;
     for (var chunk in _chunks) {
       buffer.setRange(offset, offset + chunk.length, chunk);

pkgs/web_socket_channel/lib/src/copy/io_sink.dart

@@ -15,7 +15,7 @@ import 'dart:async';
 
 class StreamSinkImpl<T> implements StreamSink<T> {
   final StreamConsumer<T> _target;
-  final Completer _doneCompleter = new Completer();
+  final Completer _doneCompleter = Completer();
   StreamController<T> _controllerInstance;
   Completer _controllerCompleter;
   bool _isClosed = false;
@@ -43,7 +43,7 @@ class StreamSinkImpl<T> implements StreamSink<T> {
 
   Future addStream(Stream<T> stream) {
     if (_isBound) {
-      throw new StateError("StreamSink is already bound to a stream");
+      throw StateError("StreamSink is already bound to a stream");
     }
     if (_hasError) return done;
 
@@ -62,9 +62,9 @@ class StreamSinkImpl<T> implements StreamSink<T> {
 
   Future flush() {
     if (_isBound) {
-      throw new StateError("StreamSink is bound to a stream");
+      throw StateError("StreamSink is bound to a stream");
     }
-    if (_controllerInstance == null) return new Future.value(this);
+    if (_controllerInstance == null) return Future.value(this);
     // Adding an empty stream-controller will return a future that will complete
     // when all data is done.
     _isBound = true;
@@ -77,7 +77,7 @@ class StreamSinkImpl<T> implements StreamSink<T> {
 
   Future close() {
     if (_isBound) {
-      throw new StateError("StreamSink is bound to a stream");
+      throw StateError("StreamSink is bound to a stream");
     }
     if (!_isClosed) {
       _isClosed = true;
@@ -111,14 +111,14 @@ class StreamSinkImpl<T> implements StreamSink<T> {
 
   StreamController<T> get _controller {
     if (_isBound) {
-      throw new StateError("StreamSink is bound to a stream");
+      throw StateError("StreamSink is bound to a stream");
     }
     if (_isClosed) {
-      throw new StateError("StreamSink is closed");
+      throw StateError("StreamSink is closed");
     }
     if (_controllerInstance == null) {
-      _controllerInstance = new StreamController<T>(sync: true);
-      _controllerCompleter = new Completer();
+      _controllerInstance = StreamController<T>(sync: true);
+      _controllerCompleter = Completer();
       _target.addStream(_controller.stream).then((_) {
         if (_isBound) {
           // A new stream takes over - forward values to that stream.