This repository was archived by the owner on Feb 24, 2025. It is now read-only.
improve pub score #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
approved these changes
Nov 26, 2018
example/example.dart
Outdated
| @@ -0,0 +1,15 @@ | |||
| // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
sorry I copied the file header from CONTRIBUTING. I updated both spots 👍
| @@ -23,13 +23,8 @@ import 'io_sink.dart'; | |||
| import 'web_socket.dart'; | |||
|
|
|||
| const String webSocketGUID = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11"; | |||
| const String _webSocketGUID = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11"; | |||
There was a problem hiding this comment.
Odd these weren't cleaned up / caught sooner. @kevmoo do we not have the proper lints turned on for this package?
There was a problem hiding this comment.
FYI dartanalyzer --fatal-infos --fatal-warnings . caught these; I just updated travis.
There was a problem hiding this comment.
Ah yes. That's our usual standard. Thanks for fixing it.
mosuem
pushed a commit
to dart-lang/http
that referenced
this pull request
Dec 11, 2024
Update analyzer and clean up warnings
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed the following:
