Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add eq, toString and hash methods to HttpProfileRedirectData #1165

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Add eq, toString and hash methods to HttpProfileRedirectData #1165

merged 3 commits into from
Mar 28, 2024

Conversation

brianquinlan
Copy link
Collaborator

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@brianquinlan brianquinlan requested a review from derekxu16 March 28, 2024 19:25
derekxu16
derekxu16 reviewed Mar 28, 2024
View reviewed changes
pkgs/http_profile/test/http_profile_response_data_test.dart
Comment on lines +30 to +36
test('equal', () {
expect(
HttpProfileRedirectData(
statusCode: 302, method: 'GET', location: 'http://somewhere'),
HttpProfileRedirectData(
statusCode: 302, method: 'GET', location: 'http://somewhere'));
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another test case below called "equal". I think you meant to delete this one, because the one below subsumes this one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to call the one below "not equal", which I've done now. Would you prefer that I combine the two tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. No, this is good. I misread the case below and thought these exact same lines appeared again, but they don't.

@brianquinlan brianquinlan merged commit a283716 into dart-lang:master Mar 28, 2024
28 checks passed
@brianquinlan brianquinlan deleted the redirecteq branch March 28, 2024 20:02
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 2, 2024
@devoncarew
[deps] rev async, boolean_selector, browser_launcher, cli_util, clock…
14e2bf8 
…, convert, crypto, csslib, fixnum, html, http, lints, logging, markdown, matcher, mime, path, pool, shelf, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, typed_data, watcher, web, web_socket_channel, webdriver, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/1556660..4796804):
  4796804  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/async#270)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/be88351..24635df):
  24635df  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/boolean_selector#57)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/7956230..c4b2c81):
  c4b2c81  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/browser_launcher#56)

cli_util (https://github.com/dart-lang/cli_util/compare/ffeb5d2..12cd216):
  12cd216  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/cli_util#98)

clock (https://github.com/dart-lang/clock/compare/daf0fad..a732a09):
  a732a09  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/clock#61)

convert (https://github.com/dart-lang/convert/compare/d4d6368..186ac22):
  186ac22  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/convert#102)

crypto (https://github.com/dart-lang/crypto/compare/69d13c9..1c7fbad):
  1c7fbad  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/crypto#166)

csslib (https://github.com/dart-lang/csslib/compare/4216525..171ed48):
  171ed48  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/csslib#198)

fixnum (https://github.com/dart-lang/fixnum/compare/570b28a..dec16eb):
  dec16eb  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/fixnum#125)

html (https://github.com/dart-lang/html/compare/327e37a..5b99b43):
  5b99b43  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/html#239)

http (https://github.com/dart-lang/http/compare/280d361..5214f76):
  5214f76  2024-04-01  dependabot[bot]  Bump actions/setup-java from 4.1.0 to 4.2.1 (dart-lang/http#1171)
  f89813e  2024-04-01  dependabot[bot]  Bump actions/cache from 4.0.1 to 4.0.2 (dart-lang/http#1169)
  c14e440  2024-03-28  Brian Quinlan  Make `test` a dev_dependency (dart-lang/http#1166)
  a283716  2024-03-28  Brian Quinlan  Add eq, toString and hash methods to HttpProfileRedirectData (dart-lang/http#1165)
  70cf298  2024-03-28  Brian Quinlan  Ignore errors added to `bodySink`s (dart-lang/http#1164)

lints (https://github.com/dart-lang/lints/compare/ead7708..df9bcbf):
  df9bcbf  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/lints#182)

logging (https://github.com/dart-lang/logging/compare/7a7bd5e..dcaf249):
  dcaf249  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/logging#160)

markdown (https://github.com/dart-lang/markdown/compare/8d07abc..782b180):
  782b180  2024-04-01  dependabot[bot]  Bump subosito/flutter-action from 2.12.0 to 2.15.0 (dart-lang/markdown#603)
  8a480f3  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/markdown#604)

matcher (https://github.com/dart-lang/matcher/compare/d954c8d..54c2798):
  54c2798  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/matcher#244)

mime (https://github.com/dart-lang/mime/compare/9a16871..0a32241):
  0a32241  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/mime#117)

path (https://github.com/dart-lang/path/compare/a7b6960..a7284b9):
  a7284b9  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/path#160)

pool (https://github.com/dart-lang/pool/compare/c118f69..8055cbb):
  8055cbb  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/pool#82)

shelf (https://github.com/dart-lang/shelf/compare/1acbc67..68cb864):
  68cb864  2024-04-01  dependabot[bot]  Bump actions/cache from 4.0.1 to 4.0.2 (dart-lang/shelf#422)
  4c55675  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/shelf#421)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/c756496..d03fd9b):
  d03fd9b  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/source_map_stack_trace#47)

sse (https://github.com/dart-lang/sse/compare/b53ba14..1ab266a):
  1ab266a  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/sse#106)

stack_trace (https://github.com/dart-lang/stack_trace/compare/155f12c..c39ae6e):
  c39ae6e  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/stack_trace#150)

stream_channel (https://github.com/dart-lang/stream_channel/compare/e02a5dd..5f72035):
  5f72035  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/stream_channel#102)

string_scanner (https://github.com/dart-lang/string_scanner/compare/a2bcdb5..8dbfddf):
  8dbfddf  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/string_scanner#70)

term_glyph (https://github.com/dart-lang/term_glyph/compare/85a4aa6..2ad48ce):
  2ad48ce  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/term_glyph#48)

test (https://github.com/dart-lang/test/compare/6a4e75a..ce3c8ca):
  ce3c8cac  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/test#2199)
  e70c291e  2024-04-01  dependabot[bot]  Bump github/codeql-action from 3.24.6 to 3.24.9 (dart-lang/test#2201)
  cb8c7a6f  2024-04-01  dependabot[bot]  Bump actions/cache from 4.0.1 to 4.0.2 (dart-lang/test#2200)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/35f97af..b61cfb4):
  b61cfb4  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/test_descriptor#62)

test_process (https://github.com/dart-lang/test_process/compare/7fe39af..94ee46d):
  94ee46d  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/test_process#54)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/9862703..d7167a2):
  d7167a2  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/test_reflective_loader#58)

typed_data (https://github.com/dart-lang/typed_data/compare/375efaa..8c7393c):
  8c7393c  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-archive/typed_data#83)

watcher (https://github.com/dart-lang/watcher/compare/21858a4..1bd2f20):
  1bd2f20  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/watcher#163)

web (https://github.com/dart-lang/web/compare/c522718..e773de9):
  e773de9  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/web#218)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/3db86bc..19d82db):
  19d82db  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/web_socket_channel#338)

webdriver (https://github.com/google/webdriver.dart/compare/73a7ac8..c80e01e):
  c80e01e  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (google/webdriver.dart#295)

yaml (https://github.com/dart-lang/yaml/compare/e598443..5a1c4be):
  5a1c4be  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/yaml#160)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/54884db..f5a92b3):
  f5a92b3  2024-04-01  dependabot[bot]  Bump actions/checkout from 4.1.1 to 4.1.2 (dart-lang/yaml_edit#70)

Change-Id: I26b63038b94c9f9b0420256e3f567d10a40f9582
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360502
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@derekxu16 derekxu16 derekxu16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianquinlan @derekxu16