-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[jnigen] Include superinterface methods #2013
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
API leaks
|
Package | Leaked API symbols |
---|---|
jni | _opaque_pthread_mutex_t _opaque_pthread_cond_t _Dart_FinalizableHandle _ReferenceType |
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/jni/lib/src/third_party/generated_bindings.dart |
pkgs/objective_c/lib/src/ns_input_stream.dart |
a7fe5f9
to
602bd58
Compare
Added a mixin on the top-level visitors, so the wrapper function only gets the visitor and checks if the stage is exactly previous stage + 1. mixin TopLevelVisitor<R> on Visitor<Classes, R> {
GenerationStage get stage;
} |
Closes #577.
Element
s in different stages of the code generation. Since the properties of the AST are added in multiple steps, theclone
method gets an enumGenerationStage until
and fills the values that are available until that stage.Foo<T>
,Bar implements Foo<String>
should have the methods ofFoo
, however all of the instances ofT
would have to be converted toString
._MethodMover
inlinker.dart
handles this part.Descriptor
intoLinker
since we need it to distinguish between duplicate methods.