Skip to content

Commit 349cc5f

Browse files
MichaelRFairhurstcommit-bot@chromium.org
authored and
commit-bot@chromium.org
committed
Mark a test as no longer a Fasta problem because #3095 is resolved.
However, the test still fails, but that's because of an inconsistency which we can revisit later. The comment describes it best. This is the stack trace of the failure: AnalysisException: Element mismatch in /test.dart at class B Caused by Bad state: Expected an element matching ``, got `x` \#0 DeclarationResolver._match (package:analyzer/src/generated/declaration_resolver.dart:585:7) \#1 DeclarationResolver.visitVariableDeclaration (package:analyzer/src/generated/declaration_resolver.dart:520:31) \#2 VariableDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:11058:49) \#3 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:7987:20) \#4 DeclarationResolver.visitVariableDeclarationList (package:analyzer/src/generated/declaration_resolver.dart:543:22) \#5 VariableDeclarationListImpl.accept (package:analyzer/src/dart/ast/ast.dart:11154:15) \#6 FieldDeclarationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:4372:17) \#7 RecursiveAstVisitor.visitFieldDeclaration (package:analyzer/dart/ast/visitor.dart:827:10) \#8 DeclarationResolver.visitFieldDeclaration (package:analyzer/src/generated/declaration_resolver.dart:226:32) \#9 FieldDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:4367:49) \#10 NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:7987:20) Bug: Change-Id: Ia0d8536e2f259c9e9c0b46366794e07796750467 Reviewed-on: https://dart-review.googlesource.com/26465 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
1 parent b3dd1a2 commit 349cc5f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart

+4-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ class CompileTimeErrorCodeTest_Kernel extends CompileTimeErrorCodeTest_Driver {
2323

2424
@override
2525
@failingTest
26-
@FastaProblem('https://github.com/dart-lang/sdk/issues/30985')
26+
// This test fails because the kernel driver element model produces a
27+
// different element model result than the regular parser produces. Once these
28+
// tests enable the faster parser (and not just the kernel driver), this
29+
// should be looked at again.
2730
test_bug_23176() async {
2831
return super.test_bug_23176();
2932
}

0 commit comments

Comments
 (0)