Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

"variable set but not used" error during build of VM #9

Closed
DartBot opened this issue Oct 10, 2011 · 3 comments
Closed

"variable set but not used" error during build of VM #9

DartBot opened this issue Oct 10, 2011 · 3 comments
Labels
closed-duplicate Closed in favor of an existing report

Comments

@DartBot
Copy link

DartBot commented Oct 10, 2011

This issue was originally filed by waqne...@gmail.com

What steps will reproduce the problem?

  1. > Follow steps to build VM mentioned at http://code.google.com/p/dart/wiki/Building#Building_the_standalone_VM

What is the expected output? What do you see instead?
I get some "variable X set but not used"-type warnings, that -Werror escalates to errors, halting the build.
As a temporary measure, I removed -Werror from all *.mk files, which allows me to build the standalone VM successfully.

What version of the product are you using? On what operating system?
Recent svn on arch linux using gcc version 4.6.1 20110819 (prerelease)

Please provide any additional information below.
Here is a full list of the warnings (without -Werror and therefor not turned to errors)

third_party/v8/src/ia32/full-codegen-ia32.cc: In member function ‘virtual void v8::internal::FullCodeGenerator::VisitCompareOperation(v8::internal::CompareOperation*)’:
third_party/v8/src/ia32/full-codegen-ia32.cc:4085:12: warning: variable ‘strict’ set but not used [-Wunused-but-set-variable]
  CXX(host) out/Debug_ia32/obj.host/v8_base/third_party/v8/src/ia32/lithium-gap-resolver-ia32.o
third_party/v8/src/ia32/lithium-codegen-ia32.cc: In member function ‘void v8::internal::LCodeGen::DoLoadKeyedFastDoubleElement(v8::internal::LLoadKeyedFastDoubleElement*)’:
third_party/v8/src/ia32/lithium-codegen-ia32.cc:2235:12: warning: variable ‘elements’ set but not used [-Wunused-but-set-variable]
third_party/v8/src/ia32/lithium-codegen-ia32.cc: In member function ‘void v8::internal::LCodeGen::DoStoreKeyedFastDoubleElement(v8::internal::LStoreKeyedFastDoubleElement*)’:
third_party/v8/src/ia32/lithium-codegen-ia32.cc:3100:12: warning: variable ‘elements’ set but not used [-Wunused-but-set-variable]
third_party/v8/src/ia32/lithium-codegen-ia32.cc:3101:12: warning: variable ‘key’ set but not used [-Wunused-but-set-variable]

third_party/v8/src/ia32/full-codegen-ia32.cc: In member function ‘virtual void v8::internal::FullCodeGenerator::VisitCompareOperation(v8::internal::CompareOperation*)’:
third_party/v8/src/ia32/full-codegen-ia32.cc:4085:12: warning: variable ‘strict’ set but not used [-Wunused-but-set-variable]
  CXX(target) out/Debug_ia32/obj.target/v8_base/third_party/v8/src/ia32/lithium-gap-resolver-ia32.o
third_party/v8/src/ia32/lithium-codegen-ia32.cc: In member function ‘void v8::internal::LCodeGen::DoLoadKeyedFastDoubleElement(v8::internal::LLoadKeyedFastDoubleElement*)’:
third_party/v8/src/ia32/lithium-codegen-ia32.cc:2235:12: warning: variable ‘elements’ set but not used [-Wunused-but-set-variable]
third_party/v8/src/ia32/lithium-codegen-ia32.cc: In member function ‘void v8::internal::LCodeGen::DoStoreKeyedFastDoubleElement(v8::internal::LStoreKeyedFastDoubleElement*)’:
third_party/v8/src/ia32/lithium-codegen-ia32.cc:3100:12: warning: variable ‘elements’ set but not used [-Wunused-but-set-variable]
third_party/v8/src/ia32/lithium-codegen-ia32.cc:3101:12: warning: variable ‘key’ set but not used [-Wunused-but-set-variable]
@DartBot
Copy link
Author

DartBot commented Oct 10, 2011

This comment was originally written by zundel@google.com

Added Duplicate label.
Marked as being merged into #8.

@DartBot
Copy link
Author

DartBot commented Oct 10, 2011

This comment was originally written by zundel@google.com

Marked as being merged into #3.

@iposva-google
Copy link
Contributor

corrected duplicate id

Marked as being merged into #43.

@DartBot DartBot added Type-Defect closed-duplicate Closed in favor of an existing report labels Oct 11, 2011
This was referenced Jun 3, 2015
Closed
Closed
This was referenced Jun 3, 2015
Closed
Closed
@peter-ahe-google peter-ahe-google mentioned this issue Jun 3, 2015
Open
@DartBot DartBot mentioned this issue Jun 3, 2015
Open
@a-siva a-siva mentioned this issue Jun 3, 2015
Closed
@gbracha gbracha mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@a-siva a-siva mentioned this issue Jun 3, 2015
Closed
@sigmundch sigmundch mentioned this issue Jun 3, 2015
Closed
@nex3 nex3 mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@sgjesse sgjesse mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@whesse whesse mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@anders-sandholm anders-sandholm mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@iposva-google iposva-google mentioned this issue Jun 3, 2015
Closed
@scheglov scheglov mentioned this issue Jun 3, 2015
Closed
This was referenced Jun 3, 2015
Closed
Closed
@itsjustkevin itsjustkevin mentioned this issue Feb 27, 2024
Open
@JgomesAT JgomesAT mentioned this issue Feb 28, 2024
Closed
@bvversoz bvversoz mentioned this issue Mar 5, 2024
Open
@adityasaxen adityasaxen mentioned this issue Mar 14, 2024
Closed
@upasana-khatiwada upasana-khatiwada mentioned this issue Mar 16, 2024
Closed
@Reinoal Reinoal mentioned this issue Mar 18, 2024
Closed
@butterbrain butterbrain mentioned this issue Apr 4, 2024
Closed
@abhisiroha abhisiroha mentioned this issue Apr 24, 2024
Closed
@eernstg eernstg mentioned this issue Jul 1, 2024
Open
@Lootwig Lootwig mentioned this issue Jul 18, 2024
Open
@the-mrinal the-mrinal mentioned this issue Jul 31, 2024
Open
@aam aam mentioned this issue Jul 31, 2024
Closed
@ailabs-software ailabs-software mentioned this issue Aug 6, 2024
Closed
@thermoworker thermoworker mentioned this issue Aug 12, 2024
Open
@theaquaflower theaquaflower mentioned this issue Aug 15, 2024
Closed
@724898928 724898928 mentioned this issue Sep 4, 2024
Open
@SwederSchellens SwederSchellens mentioned this issue Sep 24, 2024
Closed
@mjablecnik mjablecnik mentioned this issue Sep 27, 2024
Open
@ChaserVasya ChaserVasya mentioned this issue Oct 20, 2024
Open
copybara-service bot pushed a commit that referenced this issue Oct 22, 2024
@pq
[element model] fix unsafe ConstructorMember cast
f65f719 
See: b/374689139.

https://dart-review.googlesource.com/c/sdk/+/390941 is blocking an SDK roll.

Root cause:


```
Action threw an exception: type 'ConstructorMember' is not a subtype of type 'ConstructorFragment' in type cast
#0      InterfaceTypeImpl.constructors2.<anonymous closure> (package:analyzer/src/dart/element/type.dart:569)
#1      MappedListIterable.elementAt (dart:_internal/iterable.dart:435)
#2      ListIterator.moveNext (dart:_internal/iterable.dart:364)
#3      new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189)
#4      new _GrowableList.of (dart:core-patch/growable_array.dart:150)
#5      new List.of (dart:core-patch/array_patch.dart:39)
#6      ListIterable.toList (dart:_internal/iterable.dart:224)
#7      InterfaceTypeImpl.constructors2 (package:analyzer/src/dart/element/type.dart:570)
#8      _Visitor._hasConstConstructorInvocation (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:110)
#9      _Visitor.visitConstructorDeclaration (package:linter/src/rules/prefer_const_constructors_in_immutables.dart:58)
```


To verify the fix locally:

```
  solo_test_X() async {
    await assertNoErrorsInCode(r'''
class A<T> {}
''');

    var A = findElement.class_('A').instantiate(
      typeArguments: [intType],
      nullabilitySuffix: NullabilitySuffix.none,
    );
    A.constructors2;
  }
```


Bug: b/374689139
Change-Id: I70034d938d840dc0c3939db27e7116164e4617e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391483
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Open
@MLDenzzl MLDenzzl mentioned this issue Oct 28, 2024
Closed
antonbashir added a commit to antonbashir/dart that referenced this issue Nov 21, 2024
@antonbashir
Merge pull request 'fibers' (dart-lang#9) from fibers into main
57e4644 
Reviewed-on: http://git.local/dependencies/dart/pulls/9
@neoapps-dev neoapps-dev mentioned this issue Nov 28, 2024
Closed
@thermoworker thermoworker mentioned this issue Dec 18, 2024
Open
@hasimyerlikaya hasimyerlikaya mentioned this issue Dec 19, 2024
Open
@ac-arconomy ac-arconomy mentioned this issue Jan 9, 2025
Closed
@Kaushik-Mandale Kaushik-Mandale mentioned this issue Feb 5, 2025
Open
@NiclasLeichsenring NiclasLeichsenring mentioned this issue Feb 19, 2025
Closed
copybara-service bot pushed a commit that referenced this issue Feb 21, 2025
@alexmarkov
[tests] Fix flaky standalone/io/http_auth_digest_test
b2c8b31 
This test has a few independent calls to asyncExpectThrows which uses
asyncStart/asyncEnd. However, multiple top-level asyncStart/asyncEnd
are not allowed, which causes the following flaky error:

```
Unhandled exception:
Exception: Fatal: asyncStart() was called even though we are done with testing.. This is most likely a bug in your test.
#0      asyncStart (package:expect/async_helper.dart:53)
#1      asyncExpectThrows (package:expect/async_helper.dart:140)
#2      testMalformedAuthenticateHeaderWithAuthHandler.<anonymous closure> (file:///b/s/w/ir/cache/builder/sdk/tests/standalone/io/http_auth_digest_test.dart:345)
#3      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:951)
#4      Future._propagateToListeners (dart:async/future_impl.dart:980)
#5      Future._completeWithValue (dart:async/future_impl.dart:723)
#6      Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:807)
#7      _microtaskLoop (dart:async/schedule_microtask.dart:40)
#8      _startMicrotaskLoop (dart:async/schedule_microtask.dart:49)
#9      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:128)
#10     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:195)

--- Re-run this test:
python3 tools/test.py -n vm-aot-ubsan-linux-release-x64 standalone/io/http_auth_digest_test
```

This change attempts to fix this by adding a top-level asyncStart/asyncEnd
and also asyncStart/asyncEnd to the server start/shutdown to
enclose each test case into asyncStart/asyncEnd and avoid printing
"unittest-suite-success" marker before all test cases are finished.

TEST=standalone/io/http_auth_digest_test

Change-Id: I950e7c6c09f5c2144da874ab3be3cd3a130d3790
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411086
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iposva-google @DartBot