Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dart:dom indexeddb idbdatabase.createObjectStore missing optional parameters #1810

Closed
sethladd opened this issue Feb 23, 2012 · 7 comments
Closed
Labels
web-libraries Issues impacting dart:html, etc., libraries

Comments

@sethladd
Copy link
Contributor

I should be able to create an object store like this:

db.createObjectStore("customers", { keyPath: "ssn" });

But the current interface looks like this:

_IDBObjectStoreJs createObjectStore(String name) native;

@sethladd
Copy link
Contributor Author

Set owner to @rakudrama.

@rakudrama
Copy link
Member

The WebKit IDL is:

        IDBObjectStore createObjectStore(in DOMString name, in [Optional] OptionsObject options)
            raises (IDBDatabaseException);

OptionsObject is not defined - that is why the second parameter is missing.
The object has two properties (others ignored):
keyPath - string
autoIncrement - boolean

One option is to make these named optional parameters:

db.createObjectStore("customers", keyPath: "ssn", autoIncrement: false);

If OptionsObject is translated to Map<String, Dynamic>, the call would be:

db.createObjectStore("customers", { "keyPath": "ssn" });

@rakudrama
Copy link
Member

Removed Area-UI label.
Added Area-DOM label.

@rakudrama
Copy link
Member

Marked this as blocking #1310.

@vsmenon
Copy link
Member

vsmenon commented Jul 11, 2012

The API is fixed. Need to verify whether it works.


Added this to the Later milestone.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@rakudrama
Copy link
Member

JJ - can you verify?
I believe it was fixed by r11202 + r11208
Thanks!


Set owner to jjinux...@google.com.
Added Fixed label.

@sethladd sethladd added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Oct 4, 2012
@sethladd sethladd added this to the Later milestone Oct 4, 2012
copybara-service bot pushed a commit that referenced this issue Dec 9, 2022
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/4d7dc93..f2bb6e9):
  f2bb6e92  2022-12-07  Sam Rawlins  Bump to 6.1.4 (#3266)

fixnum (https://github.com/dart-lang/fixnum/compare/62916f2..e4f5e97):
  e4f5e97  2022-12-08  Michael Thomsen  Change IntegerDivisionByZeroException to UnsupportedError (#100)
  3bd726f  2022-12-08  Devon Carew  rev the sdk min to 2.19.0-0 (#99)

logging (https://github.com/dart-lang/logging/compare/f322480..0373ef8):
  0373ef8  2022-12-07  Mushaheed Syed  Add a check that throws if a logger name ends with '.' (#123)
  6d46d71  2022-12-06  Devon Carew  Create no-response.yml (#124)

protobuf (https://github.com/dart-lang/protobuf/compare/4f3e328..2706b53):
  2706b53  2022-12-07  Mahdi K. Fard  Add type to a method parameter (#782)
  a57c16a  2022-12-07  Mahdi K. Fard  Fix a typo (#781)

shelf (https://github.com/dart-lang/shelf/compare/1c21047..32e342d):
  32e342d  2022-12-08  István Soós  Prepare the release of shelf_router_generator (#316)
  06e2fe6  2022-12-08  Kevin Moore  shelf: drop non-null-safe tests (#317)
  98363fd  2022-12-06  Kevin Moore  lint: sort pub dependencies
  ad6af2a  2022-12-06  Kevin Moore  shelf_static: move RegExp creation out of every request

test (https://github.com/dart-lang/test/compare/4dceb87..73cd754):
  73cd7540  2022-12-07  Nate Bosch  Record the working directory for VM platform (#1804)
  e40274a6  2022-12-07  Nate Bosch  Restore mono_repo config (#1810)
  02d8764e  2022-12-07  Sigurd Meldgaard  Use Future for return type in runner `main()`. (#1809)
  3d6039b3  2022-12-05  Nate Bosch  Merge test selections by path (#1806)

webdev (https://github.com/dart-lang/webdev/compare/e39506e..3e2364e):
  3e2364e  2022-12-07  Elliott Brooks (she/her)  Add the Dart Debugger / Flutter Inspector panels in Chrome DevTools (#1812)
  c164231  2022-12-07  Elliott Brooks (she/her)  Small fix to the extension test (#1811)
  4bbb4d0  2022-12-06  Elliott Brooks (she/her)  Gracefully handle debugger disconnect events (#1808)
  d3892cf  2022-12-05  Elliott Brooks (she/her)  Refactor puppeteer tests to use `Worker` type (#1809)

Change-Id: I42033e849f40f209831cfb344247b24ad7731ff0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274580
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

4 participants