Skip to content

dart:dom Generator's handling of DOMStringList is confused. #1852

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
rakudrama opened this issue Feb 25, 2012 · 10 comments
Closed

dart:dom Generator's handling of DOMStringList is confused. #1852

rakudrama opened this issue Feb 25, 2012 · 10 comments
Assignees
@efortuna
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone
M2

Comments

@rakudrama
Copy link
Member

DOMStringList gets renamed and then deleted.

What needs to happen:
(1) verify DOMStringList objects exist, and ...
(2) Make DOMStringList implement List<String>
(3) Make operations / getters returning DOMStringList return List<String>
(4) special-case operations taking DOMStringList to accept List

There are only a few operations or attributes that use DOMStringList, so it might be simplest to do this all by hand.
@rakudrama
Copy link
Member Author

Marked this as blocking #1812.

@rakudrama
Copy link
Member Author

Marked this as blocking #1811.

@rakudrama
Copy link
Member Author

Removed Area-UI label.
Added Area-DOM label.

@rakudrama
Copy link
Member Author

Added this to the M1 milestone.

@vsmenon
Copy link
Member

vsmenon commented Jul 11, 2012

Marked this as blocking #1811.

@vsmenon
Copy link
Member

vsmenon commented Jul 11, 2012

Marked this as blocking #1812.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 23, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@blois
Copy link

blois commented Oct 15, 2012

Set owner to @efortuna.

@efortuna
Copy link
Contributor

Fixed with https://codereview.chromium.org/11140043/

Added Fixed label.

@rakudrama rakudrama added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Oct 17, 2012
@rakudrama rakudrama added this to the M2 milestone Oct 17, 2012
copybara-service bot pushed a commit that referenced this issue Jan 19, 2023
@devoncarew
[deps] rev dartdoc, http, protobuf, test, webdriver
af8ec4e 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/a99abd4..ed56883):
  ed56883d  2023-01-17  Parker Lougheed  Fix, cleanup, and simplify CSS (#3302)

http (https://github.com/dart-lang/http/compare/c955c7e..57c53b0):
  57c53b0  2023-01-17  Brian Quinlan  Fix a NPE that occurs when an error occurs before a response is received. (#852)

protobuf (https://github.com/dart-lang/protobuf/compare/dd04535..cc0f287):
  cc0f287  2023-01-18  Kevin Moore  Run non-null-safe tests with Dart 2 (#791)

test (https://github.com/dart-lang/test/compare/43fd928..19582a8):
  19582a8d  2023-01-19  Nate Bosch  Avoid empty `::group::` in Github reporter (#1855)
  fc4ea341  2023-01-19  Nate Bosch  Fix a test to use an still invalid URI (#1856)
  bd96213a  2023-01-18  Nate Bosch  Improve output for collections and long strings (#1852)
  9f7de8a2  2023-01-17  Nate Bosch  Remove operator extensions (#1847)
  f790feb0  2023-01-17  Nate Bosch  Add Condition abstraction (#1846)

webdriver (https://github.com/google/webdriver.dart/compare/b8c7bb5..00c887d):
  00c887d  2023-01-17  Devon Carew  rev to 3.0.2 in preparation for publishing (#268)

Change-Id: I2cbbcdce4fa510cd2458aa05dd45eed01e840c9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279329
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@efortuna efortuna

Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
M2
Development

No branches or pull requests
5 participants
@rakudrama @efortuna @vsmenon @blois @iposva-google