Missing range check for ByteArray.setRange

[sgjesse]

Running the code

void main() {
  var src = new ByteArray(2);
  var dst = new ByteArray(2);
  dst.setRange(0, 0, src, 2);
}

on debug VM (r4668) hits an assertion:

runtime/vm/object.h:3386: error: expected: (byte_offset >= 0) && (limit <= Length())

The expected result is an IndexOutOfRange exception.

[ghost]

Set owner to @lexprfuncall.

[lexprfuncall]

Both of the start parameters are not correctly validated. Exchanging the start and startFrom parameters results in the same error.

  dst.setRange(2, 0, src, 0);

I should have this fixed shortly.

---

Added Accepted label.

[lexprfuncall]

Fixed.

http://codereview.chromium.org/9560001/

As an aside, I believe that the setRange call in question is legal and should be interpreted by the corresponding library routine as a no-op. This is consistent with other parts of the core library.

---

Added Fixed label.