Skip to content

Frog generates invalid JS with a "-" in the library name. #2071

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
munificent opened this issue Mar 9, 2012 · 2 comments
Closed

Frog generates invalid JS with a "-" in the library name. #2071

munificent opened this issue Mar 9, 2012 · 2 comments
Assignees
@kasperl
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js

Comments

@munificent
Copy link
Member

Create a library like:

library('foo-bar'); // hyphen

It uses the library name as an identifier in the generated JS even though it may contain non-identifier characters.
@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, FromAreaFrog labels.

@kasperl
Copy link

kasperl commented Jun 12, 2012

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Apr 6, 2023
@devoncarew
[deps] rev boolean_selector, browser_launcher, clock, crypto, csslib,…
7573d4b 
… dartdoc, html, term_glyph, test, webdev, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/28dc03d..9fd3bae):
  9fd3bae  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#44)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/ba4e028..ed11524):
  ed11524  2023-04-04  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#40)

clock (https://github.com/dart-lang/clock/compare/93d9f56..6b2004c):
  6b2004c  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#47)

crypto (https://github.com/dart-lang/crypto/compare/8a03816..1cb1528):
  1cb1528  2023-04-04  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#142)

csslib (https://github.com/dart-lang/csslib/compare/5836863..44bfbe3):
  44bfbe3  2023-04-04  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#176)

dartdoc (https://github.com/dart-lang/dartdoc/compare/1a7952b..a0755f5):
  a0755f5f  2023-04-04  Janice Collins  Fix example modifiers (#3383)

html (https://github.com/dart-lang/html/compare/57b747d..0438b26):
  0438b26  2023-04-05  Oleh Prypin  Dart 3 compatibility: turn classes into mixins (#208)

term_glyph (https://github.com/dart-lang/term_glyph/compare/f6856e2..b110501):
  b110501  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#35)

test (https://github.com/dart-lang/test/compare/8ea4298..7832931):
  78329319  2023-04-04  Devon Carew  regenerate mono_repo (#1988)

webdev (https://github.com/dart-lang/webdev/compare/e887316..0a2804b):
  0a2804bd  2023-04-04  Elliott Brooks  Fix DevTools test (#2071)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/386fd33..5f392a1):
  5f392a1  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#48)

Change-Id: Ib9ee434634d3116db7ada89a4c31a566a28b5600
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293744
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Aug 7, 2023
@devoncarew
[deps] rev ecosystem, http, mockito, native, protobuf, shelf, sse, te…
1b1c62a 
…st, tools

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/97fc1a7..dfeda1a):
  dfeda1a  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.0.4 to 4.3.0 (#148)
  c341051  2023-08-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#147)
  c1c8d1f  2023-08-01  Moritz  Update health.yaml (#146)
  31c5d21  2023-07-27  Devon Carew  misc updates to the label management tool (#145)

http (https://github.com/dart-lang/http/compare/4289e8b..7e9ed12):
  7e9ed12  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.2.0 to 4.3.0 (#1000)
  e8e35db  2023-07-31  Alex James  [java_http] send request body (#995)

mockito (https://github.com/dart-lang/mockito/compare/b421775..ff79de6):
  ff79de6  2023-08-04  Nate Bosch  Allow the latest package:analyzer

native (https://github.com/dart-lang/native/compare/f0dc3e9..0187d0e):
  0187d0e  2023-08-07  Daco Harkes  [native_assets_cli] Rename `Asset` `name` to `id` (#113)
  1b984c7  2023-08-07  Daco Harkes  [native_assets_cli] Replace `TypeError`s with `FormatException`s (#112)
  b2b26db  2023-08-07  Daco Harkes  [native_assets_builder] Stop throwing from BuildRunner (#108)
  c940ac8  2023-08-03  Daco Harkes  [native_assets_builder] return build dependencies (#107)
  63daab8  2023-08-03  Daco Harkes  [native_assets_builder] Fix dry run directory structure (#110)
  3f26f20  2023-08-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#104)

protobuf (https://github.com/dart-lang/protobuf/compare/d9e8a31..217c030):
  217c030  2023-08-02  Ömer Sinan Ağacan  Avoid holding onto the buffer when parsing unknown length-delimited fields (#863)

shelf (https://github.com/dart-lang/shelf/compare/bd59ead..73edd2b):
  73edd2b  2023-08-01  dependabot[bot]  Bump actions/labeler from 4.2.0 to 4.3.0 (#370)

sse (https://github.com/dart-lang/sse/compare/e241085..8cc5b11):
  8cc5b11  2023-08-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.0.0 to 2.1.1 (#86)

test (https://github.com/dart-lang/test/compare/92eb0f7..5d571d6):
  5d571d64  2023-08-03  Nate Bosch  Add --fail-fast flag (#2040)
  a9dcce29  2023-08-01  Nate Bosch  Rerun publish workflow on more PR changes (#2070)
  50d558b2  2023-08-01  dependabot[bot]  Bump github/codeql-action from 2.20.1 to 2.21.2 (#2071)
  9e124e9f  2023-07-31  Nate Bosch  Prepare to publish (#2069)

tools (https://github.com/dart-lang/tools/compare/af3fc99..f14bf2e):
  f14bf2e  2023-08-07  Elias Yishak  Remove unused NoOp classes (#138)
  a2aa1c3  2023-08-07  Devon Carew  add CI; update readme (#140)
  d424568  2023-08-06  Devon Carew  add usage docs to package:cli_config (#141)
  921611a  2023-08-03  Elias Yishak  Survey handler feature (#109)

Change-Id: Iee720272733822d11caf46adcae516f12f11abec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318801
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kasperl kasperl

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @munificent @kasperl @anders-sandholm