Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generated JS fails to launch on Windows #2114

Closed
danrubel opened this issue Mar 12, 2012 · 3 comments
Closed

Generated JS fails to launch on Windows #2114

danrubel opened this issue Mar 12, 2012 · 3 comments
Assignees
Labels
closed-duplicate Closed in favor of an existing report os-windows P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@danrubel
Copy link

[user feedback]
Your Javascript generation has flaws.

Just using a simple (unedited) dart file that gets generated by the editor, supplying the following code:

import('dart:html');

class test1 {

 test1() {
 }

 void run() {
   write("Hello World!");
 }

 void write(String message) {
   // the HTML library defines a global "document" variable
   document.query('#status').innerHTML = message;
 }
}

void main() {
 new test1().run();
}

This code fails to run in a browser not running the VM due to the following Javascript error:

Object.defineProperty is not a function
file:///C:/Research/darttest/test1/test1.dart.js
Line 5

Your technology is unusable. I will not use this or recommend it to anyone. In fact, I will recommend that it be avoided to all my many contacts.

Come back when you have something people can use...

////////////////////////////////////////////////////////////////////////////////////
Editor Version: 5104

@DartBot
Copy link

DartBot commented Mar 15, 2012

This comment was originally written by jimhug@google.com


This looks pretty critical to me to at least understand which browser the issue is occurring in. My guess is that this is an issue with pre-IE9 browsers in which case we need to clearly state that these browsers will not be supported.


Set owner to @kasperl.
Removed Priority-Medium label.
Added Priority-Critical label.

@kasperl
Copy link

kasperl commented Mar 16, 2012

The problem is that we have no way of getting more information (as far as I can tell). I really don't think this issue is critical at this point.

I am all for making it easier for our users to diagnose these issues though. Any browser that does not support Object.defineProperty will run into trouble and we can definitely give a better error message in that case. Any opinions on how we should notify our users? Alert?


Removed Priority-Critical label.
Added Priority-High label.

@kasperl
Copy link

kasperl commented Apr 14, 2012

Added Duplicate label.
Marked as being merged into #2198.

@danrubel danrubel added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures os-windows closed-duplicate Closed in favor of an existing report labels Apr 14, 2012
copybara-service bot pushed a commit that referenced this issue Jan 8, 2024
matcher (https://github.com/dart-lang/matcher/compare/fcbd361..d9cf4f6):
  d9cf4f6  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#240)
  7ea9047  2023-12-13  Kevin Moore  Update test_api dependency, bump & fix lints, prepare release (#237)
  050fdda  2023-12-13  Kevin Moore  blast_repo fixes (#238)

mockito (https://github.com/dart-lang/mockito/compare/57a7c82..e15e000):
  e15e000  2023-12-14  Sam Rawlins  Bump mockito to 5.4.4
  a2a6566  2023-12-14  Copybara-Service  Merge pull request #726 from provokateurin:chore/deps/test_api-0.7
  bda332c  2023-12-14  jld3103  chore(deps): Allow test_api 0.7
  9bd6fb0  2023-12-12  Paul Berry  Remove mockito pre-null-safety tests.

test (https://github.com/dart-lang/test/compare/43ff5bf..846d73e):
  846d73ee  2024-01-01  dependabot[bot]  Bump actions/upload-artifact from 3.1.3 to 4.0.0 (#2165)
  0ab56790  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#2167)
  3b960c3e  2024-01-01  dependabot[bot]  Bump github/codeql-action from 2.22.8 to 3.22.12 (#2166)
  30543cae  2023-12-19  Nate Bosch  Add more logging around iframe startup (#2160)
  e56a5e22  2023-12-13  Jacob MacDonald  small cleanup in catch (#2159)
  15b39372  2023-12-13  Jacob MacDonald  handle missing package config files (#2158)
  9667cca8  2023-12-13  Jacob MacDonald  release test_api 7.0.0, test_core 6.0.0, and test 1.25.0 (#2156)
  b3fb1486  2023-12-13  Nate Bosch  Remove support for Internet Explorer (#2114)
  48a2bc3d  2023-12-13  Derek Xu  Update the package:vm_service constraint to allow version 14.x (#2157)

Change-Id: I386444652c47cd14a61665599d86dc3a7669a2fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345341
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
closed-duplicate Closed in favor of an existing report os-windows P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants