Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test.dart does not work with --valgrind. #2131

Closed
larsbak opened this issue Mar 13, 2012 · 2 comments
Closed

test.dart does not work with --valgrind. #2131

larsbak opened this issue Mar 13, 2012 · 2 comments
Assignees
@whesse
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@larsbak
Copy link

larsbak commented Mar 13, 2012

tools/test.py --valgrind
Unhandled exception:
Expect.stringEquals(expected: <python -u /home/bak/dart/dart/runtime/tools/valgrind.py out/Debug_ia32/dart --ignore-unrecognized-flags /home/bak/dart/dart/tests/corelib/src/StringFromListTest.dart >", <python -u /home/bak/dart/dart/runtime/tools/valgrind.py out/Debug_ia32/dart --ignore-unrecognized-flags /home/bak/dart/dart/tests/corelib/src/StringFromListTest.dart>) fails
Diff:
...[ out/Debug_ia32/dart --ignore-unrecognized-flags /home/bak/dart/dart/tests/corelib/src/StringFromListTest.dart ]...
...[ out/Debug_ia32/dart --ignore-unrecognized-flags /home/bak/dart/dart/tests/corelib/src/StringFromListTest.dart ]...
 0. Function: 'Expect._fail@127eafe4' url: 'bootstrap' line:1457 col:5
 1. Function: 'Expect.stringEquals' url: 'bootstrap' line:1388 col:10
 2. Function: 'TestCase.TestCase.' url: '/home/bak/dart/dart/tools/testing/dart/test_runner.dart' line:116 col:28
 3. Function: 'StandardTestSuite.enqueueStandardTest' url: '/home/bak/dart/dart/tools/testing/dart/test_suite.dart' line:367 col:14
 4. Function: 'StandardTestSuite.enqueueTestCaseFromTestInformation' url: '/home/bak/dart/dart/tools/testing/dart/test_suite.dart' line:343 col:26
 5. Function: 'StandardTestSuite.function' url: '/home/bak/dart/dart/tools/testing/dart/test_suite.dart' line:393 col:41
 6. Function: 'StandardTestSuite.processFile' url: '/home/bak/dart/dart/tools/testing/dart/test_suite.dart' line:416 col:21
 7. Function: '_Directory@14117cc4.function' url: 'dart:io' line:616 col:39
 8. Function: '_ReceivePortImpl@6be832b._handleMessage@6be832b' url: 'dart:isolate' line:281 col:22
@whesse
Copy link
Contributor

whesse commented Mar 13, 2012

This is just an issue with trimming the spaces if the prefix or suffix is empty. Fixing it.

Set owner to @whesse.
Added Accepted label.

@whesse
Copy link
Contributor

whesse commented Apr 10, 2013

Fixed then, and verified now that it is not broken.

Added Fixed label.

@larsbak larsbak added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Apr 10, 2013
copybara-service bot pushed a commit that referenced this issue Jun 7, 2023
@jcollins-g
[deps] rev dartdoc, lints, native, webdev
80a9e51 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/0c8feac..449478c):
  449478c7  Tue Jun 6 20:04:19 2023 -0700  Sam Rawlins  Search: specify package rank in generation; distinguish non-core Dart libs (#3427)
  81af1bf3  Tue Jun 6 17:31:02 2023 -0700  Janice Collins  Prepare for dartdoc 6.3.0. (#3430)
  2b7340d3  Tue Jun 6 17:30:40 2023 -0700  Sam Rawlins  Explicitly export Kind; for internal customer (#3431)
  896540c0  Mon Jun 5 19:39:10 2023 +0000  dependabot[bot]  Bump github/codeql-action from 2.3.5 to 2.3.6 (#3429)

lints (https://github.com/dart-lang/lints/compare/fc74ce0..4b79906):
  4b79906  Tue Jun 6 15:15:22 2023 -0500  Parker Lougheed  Link to 'dart fix' docs in table header (#132)
  b7766d6  Tue Jun 6 09:05:20 2023 -0700  Devon Carew  add 'has quick-fix' checkboxes to the package's readme (#131)

native (https://github.com/dart-lang/native/compare/c851e69..973f3ed):
  973f3ed  Tue Jun 6 10:26:58 2023 +0000  Daco Harkes  [native_assets_cli] Add `dry_run` option (#59)

webdev (https://github.com/dart-lang/webdev/compare/b10d62b..3d7f546):
  3d7f546f  Mon Jun 5 16:24:16 2023 -0700  Elliott Brooks  Add Webdev installation test (#1935)
  9297c663  Mon Jun 5 14:31:43 2023 -0700  Elliott Brooks  Remove unnecessary `async` keywords(#2130)
  6b112b06  Mon Jun 5 12:45:34 2023 -0700  Elliott Brooks  Run DCM workflow against PR branch (#2131)

Change-Id: I6728516c13c1d45f8bbd65c266076c6028ed45ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307962
Reviewed-by: Devon Carew <devoncarew@google.com>
Auto-Submit: Janice Collins <jcollins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@whesse whesse

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whesse @larsbak