Skip to content

Some snapshot reader functions do not correctly allocate new objects #2233

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
lexprfuncall opened this issue Mar 20, 2012 · 2 comments
Closed

Some snapshot reader functions do not correctly allocate new objects #2233

lexprfuncall opened this issue Mar 20, 2012 · 2 comments
Assignees
@a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@lexprfuncall
Copy link

Snapshot readers must use a special allocation path. If not, the GC scope assertions will be tripped. At present, BigInt and JSRegExp are using ordinary allocation paths in the snapshot reader. If, for example, a BigInt is written out into a snapshot, the VM will abort at startup. There may be other cases of this condition.
@lexprfuncall
Copy link
Author

Added Area-VM, Accepted labels.

@a-siva
Copy link
Contributor

a-siva commented Mar 24, 2012

https://chromiumcodereview.appspot.com//9835074

Added Fixed label.

@lexprfuncall lexprfuncall added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Mar 24, 2012
dart-bot pushed a commit that referenced this issue Oct 29, 2019
@sigurdm
Update the pub version
3ce89fd 
Includes the following commits:
80ac76400ff58fde3c5a335d860d196c3febe837 Warn about authors field in pubspec.yaml
6b6e02fcdd8094ccbba919b2fdc74947b1cebb71 Warn about old flutter plugin registration format (#2233)
8308acbc48ebd4da4ab7f45169af8dee4df18e79 Language versioning
b18d4f6a5d035f4f72ef187e9cdb133d18848c2d update doc
408bdd58ab01689fd82cc036b4142f7b592b4ba0 Added utility for faster local testing (#2235)
055fc19d2e06e819dbd47b3b56909c47bd893f66 Upgraded package:yaml to 2.2.0 (#2237)
0f3baf7abb13702f7fb1ff3709c584065df1435c Remove unused Map `availableVersions`
cfa9dc760b6b601f9473e65d15f15b60a319336d Fix to show proper error message when git is not installed (#2209)
d99b0d58f4059d7bb4ac4616fd3d54ec00a2b5d4 Rephrase warnings for missing deps (#2203)
76b8c30395b37f96d3db3e842344cc842bdd7c24 Don't mention 'transformed dependencies'. (#2199)
4bd65e0f54e6e4540f03467b0272a5666e8d54ba return the hashCode of the description (#2198)
92b52682e8fc6eed9ef2e77ed890647f75570165 Test more pre-release behavior. (#2175)
066ac118d406500f672339e25f0154af9321deac update to latest pkg:analyzer (#2172)
289804a5d2c9746b4e86c271c2abcfe17417e20f Minor typo fixed (#2166)

Change-Id: I3922bcaacb5399853a291b92d7192d21f719d224
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123404
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
copybara-service bot pushed a commit that referenced this issue Sep 19, 2023
@devoncarew
[deps] rev ecosystem, http, native, tools, webdev
8507f55 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/babf5d1..ed39318):
  ed39318  2023-09-14  Devon Carew  validate a prerelease setup-dart version (#169)
  b3dc96f  2023-09-14  Devon Carew  fix an issue rendering multi-line changelogs (#171)

http (https://github.com/dart-lang/http/compare/e19094a..decefa6):
  decefa6  2023-09-15  Brian Quinlan  Remove invalid status line tests and replace them with valid status line tests (#1018)

native (https://github.com/dart-lang/native/compare/4f4d7c3..a5d8809):
  a5d8809  2023-09-18  Daco Harkes  [native_toolchain_c] Bump version (#140)

tools (https://github.com/dart-lang/tools/compare/1512f3d..63d8267):
  63d8267  2023-09-18  Elias Yishak  Restrict surveys for certain tools (#161)
  5a1fc54  2023-09-14  Devon Carew  validate a pre-release setup-dart action (#160)

webdev (https://github.com/dart-lang/webdev/compare/501ccc2..d7e0d1f):
  d7e0d1ff  2023-09-15  Devon Carew  test the latest setup-dart action (#2233)
  4e231bc3  2023-09-14  Elliott Brooks  Fix copying over `client.dart.js` to `client.js` when build DWDS  (#2232)

Change-Id: Iac8741aed14591402b1c8a3cd33dc00e4648ac0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326720
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lexprfuncall @a-siva