Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Dartium: doc comments on top of file fail in Dartium #2295

Closed
DartBot opened this issue Mar 25, 2012 · 3 comments
Closed

Dartium: doc comments on top of file fail in Dartium #2295

DartBot opened this issue Mar 25, 2012 · 3 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant
Milestone
M1

Comments

@DartBot
Copy link

DartBot commented Mar 25, 2012

This issue was originally filed by marti...@probst.io

Given this source:

/** My awesome file */

library("awesomeness");

...

Dartium fails stating that #library must be the first in the file. Removing one star from '/**' (i.e. turning the comment into a regular multiline comment) fixes the issue.
@DartBot
Copy link
Author

DartBot commented Mar 26, 2012

This comment was originally written by antonm@google.com

cc @iposva-google.
Added Area-VM, Triaged labels.

@iposva-google
Copy link
Contributor

Works fine in the standalone VM.

Removed Area-VM label.
Added Area-Dartium label.

@DartBot
Copy link
Author

DartBot commented Jun 4, 2012

This comment was originally written by antonm@google.com

works perfectly now

Added this to the M1 milestone.
Added AssumedStale label.

@DartBot DartBot added Type-Defect closed-obsolete Closed as the reported issue is no longer relevant labels Jun 4, 2012
@DartBot DartBot added this to the M1 milestone Jun 4, 2012
dart-bot pushed a commit that referenced this issue Jan 16, 2020
@sigurdm
Bump pub revision in DEPS
be1ddc8 
New commits included in this revision:
```
$ git log --pretty=oneline 4d8ecbd409d773fec47da33b7e6c8db0b51487fd..429a06039d185149f387a65e3503b0693ce6d24e
429a06039d185149f387a65e3503b0693ce6d24e (HEAD -> master, origin/master, origin/HEAD) Parallel fetching of available versions (#2280)
6705b085b9bf4754a4c8002a070f436f115dc4d1 Retry on all SocketExceptions (#2254)
a1820273b9f3c7bb5a13d26cd14d30d5bab187ae Use a unqiue file name for the snapshot during testing. (#2303)
72686563e767f8a359e48a267a2c323953a6a0ef Include osx and windows testing on Travis (#2299)
a7a66821d13920b9b22cc394dfa55c679e971e40 Fail travis for lints and warnings (#2301)
25aa24c023453f064dad8f3cce1bbd55269d0efa Omit languageVersion when there is no SDK constraint (#2300)
82e60a3dcb3afe753563e7d304827fb650bc4833 Use LOCALAPPDATA for system cache on windows (#2297)
ceaa86f2c7eb35f044b4c202268a17361de68d13 Enforce and fix lints from package:pedantic (#2291)
6ce1606564352c305bd0f6d97704f0f7f6ebbca0 Use more collection literals for args (#2293)
be245e6baeebb71aaf3b3a260fcfbbb011a9a7e0 Rename some test utilities from Mock to Fake (#2294)
f7638ce85298df7d9e73d717dd4d81f499681720 Refactor Set.add following !Set.contains (#2295)
390022b24bc076cb934385936ac7904f045a75ba Filter out `null` from `getCachedPackages`. (#2292)
0eea0c4421ed0b83c8597b62dacf68b93de172b9 Fix existing hints and lints (#2290)
7cf2fe860a40517ccb65f5efdda9e4dc350142c3 promote strict deps failures to errors from warnings (#2289)
```

Change-Id: I62782b29e16092114940df00811bfdd20c8045fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131839
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
M1
Development

No branches or pull requests
2 participants
@iposva-google @DartBot