Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Problem with string and numeral concatenation #2679

Closed
DartBot opened this issue Apr 21, 2012 · 3 comments
Closed

Problem with string and numeral concatenation #2679

DartBot opened this issue Apr 21, 2012 · 3 comments
Labels
closed-as-intended Closed as the reported issue is expected behavior

Comments

@DartBot
Copy link

DartBot commented Apr 21, 2012

This issue was originally filed by daniel....@gmail.com

What steps will reproduce the problem?

  1. write: print(1 + 'string');
  2. run the code and it will return the error

But, if you do:

  1. write: print('string' + 1);
  2. run the code and no error will be showed

What is the expected output? What do you see instead?
Probably both cases were supposed to return an error

What version of the product are you using? On what operating system?
OS X Lion, dart editor
Version 0.1.0.201204181857, Build 6722
Dart SDK version 6714, Dartium version
@rakudrama
Copy link
Member

The second example works because String.operator+ calls toString on the argument.

However, both examples will soon be an error - the reason is that + for strings is being removed completely.

The recommended approach is to use interpolation:
'${1}string' or 'string${1}'.
Or to use StringBuffer.

@madsager
Copy link
Contributor

Closing this out because the + operator on strings will be illegal for all uses soon.

Added AsDesigned label.

@DartBot
Copy link
Author

DartBot commented Apr 23, 2012

This comment was originally written by daniel....@gmail.com

Thanks for this explanation!

@DartBot DartBot added Type-Defect closed-as-intended Closed as the reported issue is expected behavior labels Apr 23, 2012
dart-bot pushed a commit that referenced this issue Oct 14, 2020
@sigurdm
Bump pub
da9f410 
git log --oneline cf9795f3bb209504c349e20501f0b4b8ae31530c..f0c7771b38155d3829a60d60b5dba2784b100811
f0c7771b Set first version with null safety to 2.12 (#2684)
df1140af Warn from get, when mixed mode (#2590)
765778c0 Simplify test detection (#2682)
afd66ea2 Inline the single test asset. (#2681)
059e4796 Simplify the logic for unicode and colors in output (#2679)
35ddaec2 Dartify test tool (#2680)
62f26401 Example for User-Agent (#2678)
e8b4b114 fixes: #2670 pub global activate commands always exit cmd on windows. (#2671)
93e703b1 Improve stack traces in many tests (#2673)
5b540a39 Fix experiments tests for Dart 2.11 (#2672)
b0ac77d8 Bump dependency on pkg:analyzer (#2662)
73f0906e Removed @alwaysThrows (#2642)
88e0a83c Fixed bug in adding dependency to empty dependencies key (#2640)
135d9fa0 Pub add/remove now remove dependencies key if it makes them empty (#2639)
f4cc9673 Fix "pubpsec" typo (#2641)
4686d74d Adding an existing package is now a dataError (#2638)
1e93f47c Checks pubspec keys for potential typos (#2616)
fa5f51ef Vendor yaml_edit (#2633)
ac6d307f Adding a `pub remove` command (#2620)
9d236e00 Adding the `pub add` command (#2618)
04e237f7 Drop upper bound instead of using "any" while resolving in "pub outdated" (#2623)
93954f33 Use InternetAddress.tryParse over try/catch (#2626)
638c81c9 Refine publishing message (#2624)


Allow github


Embed pub as a library into dartdev

Change-Id: Iadc6acb5c3425dfb8848db89820e6c9c8caf16ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167574
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
closed-as-intended Closed as the reported issue is expected behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakudrama @madsager @DartBot