I can't navigate (F3) in sources of Dart library

[stevemessick]

I can't navigate (F3) in sources of Dart library.
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 7905

[danrubel]

[from: scheglov@google.com]

com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.resolveUnit(CompilationUnit, Collection<DartCompilationError>)
  This method prepares "suppliedSources" with CompilationUnit content from unsaved editor and calls
com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.ResolverRunnable.ResolverRunnable(LibrarySource, URI, Map<URI, String>, Map<URI, DartUnit>, boolean, Collection<DartCompilationError>)
  ...which creates librarySource=LibraryWithSuppliedSources

  However in
  com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.secureAnalyzeLibrary(LibrarySource, Map<URI, DartUnit>, CompilerConfiguration, DartArtifactProvider, DartCompilerListener)
  ...this "librarySource" is not used as is, instead only library URI is extracted, so "suppliedSources" is ignored and unit content from the File is parsed.

[danrubel]

Repro:

• Load sunflower... F3 works.
• Insert the following before the drawFrame(...) method, but don't save

f2() {
  int vvv;
  vvv = 2;
}

* Now all F3 on references in code after inserted f2() method are wrong... almost as if the offset is wrong.

• Save and same behavior
• Make another inconsequential edit and Save... then F3 works again.

Konstantin dug into this and came up with the notes entered above.
Might be a in memory / on disk mismatch when resolving using AnalysisServer.

[bwilkerson]

Konstantin's notes indicate that this is indeed a problem with the way the compiler is being invoked and that what's happening is that the version of the resource that is on disk is being used instead of the version in the editor. It isn't clear that it has anything to do with analysis server, but you still might be able to find and fix the problem faster than I can. Fel free to re-assign it to me if you want.

---

Set owner to @danrubel.

[stevemessick]

This is a show-stopper for mark occurrences. If I turn off the analysis server then mark occurrences works correctly in modified files. The problem is as scheglov reported: DartCompilerUtilities.secureAnalyzeLibrary() no longer uses the editor buffers provided by the client caller. The true branch of the code that checks if the analysis serve is enabled does not play nicely with editor buffers; it goes to disk every time. The buffer contents are available in the "librarySource" object but only the URI is used from it. See DartCompilerUtilities line 849.

---

Removed Priority-Medium label.
Added Priority-High label.

[keertip]

[from sethladd]

Open Declaration for a class imported from a packaged does not work. I have confirmed I have the package installed, the Dart Editor perference is set, and the red underlines are gone. The program works fine. I tried multiple different classes that are imported from packages.

[clayberg]

Added this to the M1 milestone.

[danrubel]

http://codereview.chromium.org/10545044/

---

Added Fixed label.