Skip to content

Some tests contain _ as first character in named argument name #3495

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
DartBot opened this issue Jun 11, 2012 · 1 comment
Closed

Some tests contain _ as first character in named argument name #3495

DartBot opened this issue Jun 11, 2012 · 1 comment
Labels
closed-duplicate Closed in favor of an existing report

Comments

@DartBot
Copy link

DartBot commented Jun 11, 2012

This issue was originally filed by zundel@google.com

Ran into this problem when adding the check specified in spec v 0.10 section 6.2:

"It is a compile-time error if the name of a named optional parameter begins with an character."

ERROR|RESOLVER|NAMED_PARAMETERS_CANNOT_START_WITH_UNDER|file:/home/zundel/dart-all/dart/tests/language/named_parameters_with_object_property_names_test.dart/named_parameters_with_object_property_names_test.dart|162|1|70|Named parameters cannot start with an '_' character
   161: }
   162: globalMethod___noSuchMethod__([noSuchMethod]) => noSuchMethod;
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Affects test: language/named_parameters_with_object_property_names_test.dart

Another problem is a method in the dartium library which I will file separately.
@DartBot
Copy link
Author

DartBot commented Jun 11, 2012

This comment was originally written by zundel@google.com

Added Duplicate label.
Marked as being merged into #2137.

@DartBot DartBot added Type-Defect closed-duplicate Closed in favor of an existing report labels Jun 11, 2012
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
copybara-service bot pushed a commit that referenced this issue Aug 4, 2022
@sigurdm
Bump pub to ac7db6c07318efa4a8712110275eaf70f96a6d00
29e56e9 
Changes:
```
> git log --format="%C(auto) %h %s" 9bf4289..ac7db6c
 https://dart.googlesource.com/pub.git/+/ac7db6c0 Fix string shortening (#3512)
 https://dart.googlesource.com/pub.git/+/4ed0d5cd Add pubspec_overrides.yaml to basicIgnoreRules (#3503)
 https://dart.googlesource.com/pub.git/+/d8f4c549 Remove all support for legacy .packages file (#3507)
 https://dart.googlesource.com/pub.git/+/1722b6a8 Update 2-BUG.md (#3495)
 https://dart.googlesource.com/pub.git/+/e60ef647 Add lint avoid_print (#3475)

```

Diff: https://dart.googlesource.com/pub.git/+/9bf4289d6fd5d6872a8929d6312bbd7098f3ea9c~..ac7db6c07318efa4a8712110275eaf70f96a6d00/
Change-Id: I730a048dbf10992270f74ddde47824cc071a3994
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253663
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DartBot