Skip to content

[cfe] Implement support for dynamic checks on parameters that are covariant-by-declaration due to inheritance #47074

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
eernstg opened this issue Sep 1, 2021 · 4 comments
Assignees
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. P2 A bug or feature request we're likely to work on

Comments

@eernstg
Copy link
Member

eernstg commented Sep 1, 2021

This is the front end specific issue for #47072, which has the details.

Note that the front end may already have the new behavior (it already succeeds in a run of the tests added by https://dart-review.googlesource.com/c/sdk/+/208504).

@devoncarew
Copy link
Member

@johnniwinther - can you provide a very rough estimate of how long this would take to do? We're trying to get breadbox estimates of the ~5 impl. tasks for this language change.

@johnniwinther
Copy link
Member

The CFE part test 1-2 days (more). I'm working on it now.

@johnniwinther johnniwinther added the P2 A bug or feature request we're likely to work on label Oct 12, 2021
@johnniwinther
Copy link
Member

A rough cornercase turned up. I'm working on a fix, but we can release this feature without it.

@johnniwinther
Copy link
Member

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

3 participants