Skip to content

[DDC] Implement support for dynamic checks on parameters that are covariant-by-declaration due to inheritance #47078

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
eernstg opened this issue Sep 1, 2021 · 5 comments
Closed

[DDC] Implement support for dynamic checks on parameters that are covariant-by-declaration due to inheritance #47078

eernstg opened this issue Sep 1, 2021 · 5 comments
Assignees
@nshahan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Milestone
October Release (...

Comments

@eernstg
Copy link
Member

eernstg commented Sep 1, 2021

This is the DDC specific issue for #47072, which has the details.
@eernstg eernstg added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Sep 1, 2021
@eernstg eernstg mentioned this issue Sep 1, 2021
Closed
5 tasks
@devoncarew
Copy link
Member

@nshahan (or @sigmundch) - can you provide a very rough estimate of how long this would take to do? We're trying to get breadbox estimates of the ~5 impl. tasks for this language change.

@nshahan
Copy link
Contributor

nshahan commented Sep 3, 2021

@eernstg If the tests you added in https://dart-review.googlesource.com/c/sdk/+/208504 are all passing in DDC already is it reasonable to close this issue?

@eernstg
Copy link
Member Author

eernstg commented Sep 3, 2021

Wouldn't DDC receive kernel code from the CFE? In that case it is probably a good idea to wait for completion of #47074, and then re-check that it still works.

@devoncarew
Copy link
Member

@nshahan - assigning you as the likely owner.

@sigmundch sigmundch added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Oct 12, 2021
@johnniwinther
Copy link
Member

This is already handled in DDC.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nshahan nshahan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Milestone
October Release (Dart 2.15 beta 3 + s...
Development

No branches or pull requests
5 participants
@devoncarew @sigmundch @nshahan @eernstg @johnniwinther