Small doc and style cleanup #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some docs to be noun phrases for classes. Remove some docs that are wholly redundant against the signature. Remove an unnecessary private typedef. Rename some methods that start with "get".
kevmoo
approved these changes
Dec 5, 2019
kevmoo
reviewed
Dec 5, 2019
| @@ -153,7 +153,7 @@ Map<String, String> _adjustHeaders(Map<String, String> headers, Body body) { | |||
| var sameEncoding = _sameEncoding(headers, body); | |||
| if (sameEncoding) { | |||
| if (body.contentLength == null || | |||
| findHeader(headers, 'content-length') == body.contentLength.toString()) { | |||
| findHeader(headers, 'content-length') == '${body.contentLength}') { | |||
There was a problem hiding this comment.
kept it as 1 line instead of splitting
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some docs to be noun phrases for classes.
Remove some docs that are wholly redundant against the signature.
Remove an unnecessary private typedef.
Rename some methods that start with "get".