-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
1 adding dash analytics #2
1 adding dash analytics #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a pass through with some comments. I generally didn't look at the library implementation; has this already been reviewed? And or, should somebody else review the impl?
Yes, for the most part, the implementation has been reviewed at my repo github.com/eliasyishak/dash_analytics – do we need to preserve those conversations somehow in this repo? |
I don't think that's necessary. We could retain the commit history if we wanted to; that would be more useful if there had been multiple authors over time say (I don't think we need to figure out the git commands for that in this case). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; feel free to land when you're comfortable with the PR
Do consider separating out the content in the readme a bit as per https://github.com/dart-lang/tools/pull/2/files#r1105023051.
Adding the initial commit for
dash_analytics
, a package intended to only be used within Dash tooling to unify analytics across different Dash tools in Google Analytics 4.