Add DashEvent for toggling telemetry collection + send event whenever toggled
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Events can have a maximum of 25 user properties - User property names must be 24 characters or fewer - User property values must be 36 characters or fewer (only for `tool` name) - Event names must be 40 characters or fewer, may only contain alpha-numeric characters and underscores, and must start with an alphabetic character
|
Note: confirm that the events are being sent correctly with main GA instance |
bwilkerson
approved these changes
Mar 3, 2023
|
|
||
| // Extract the last log item to check for the keys | ||
| lastLogItem = jsonDecode(logFile.readAsLinesSync().last); | ||
| expect((lastLogItem['events'] as List).last['name'], |
There was a problem hiding this comment.
Consider extracting (lastLogItem['events'] as List).last as a helper or extension method, given that it occurs 4 times in this method alone.
There was a problem hiding this comment.
I'll expand this out if an additional test needs this functionality
eliasyishak
deleted the
22-add-dashevent-for-toggling-telemetry-collection
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new event
DashEvent.analyticsCollectionEnabledwhich will be sent whenever the developer has toggled their telemetry collection status. This will help us understand any users that have opted out and maybe even opted back in.Additionally, the
setTelemetrymethod withinAnalyticshas also been modified so that an event is sent to GA every time this state is toggled. It avoids using thesendEventmethod because that method is blocked from sending anything if the user has opted out previously.