Skip to content

Add variadic arguments #343

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2025
Merged

Add variadic arguments #343

merged 3 commits into from
Feb 25, 2025

Conversation

ykmnkmi
Copy link
Contributor

@ykmnkmi ykmnkmi commented Feb 21, 2025

Fixes #340. Related #292.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srujzs srujzs self-requested a review February 21, 2025 17:20
srujzs
srujzs reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good % my comments! Thanks for taking this on! I noted the places there are breaking changes.

I'm tempted to say the breakages are currently okay since it's currently a wrong binding, but it is possible that someone could've called these members with the right arguments and it would've worked e.g. setInterval(handler, 0.toJS).

I think we don't have a choice but to rev the version, which in turn requires more churn. :(

srujzs
srujzs approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR!

@srujzs srujzs merged commit e2f9741 into dart-lang:main Feb 25, 2025
15 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 7, 2025
@devoncarew
[deps] rev dartdoc, ecosystem, i18n, protobuf, shelf, sync_http, test…
2d24752 
…, tools, vector_math, web, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/34561d6..6c770bf):
  6c770bfb  2025-03-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/dartdoc#4011)
  06233c76  2025-02-26  Parker Lougheed  Use nested scss in nav and footer styles (dart-lang/dartdoc#4006)
  4847677c  2025-02-26  Sam Rawlins  Support the stats flag when documenting the testing package (dart-lang/dartdoc#4008)

ecosystem (https://github.com/dart-lang/ecosystem/compare/06bbbff..a3cc42d):
  a3cc42d  2025-03-06  Devon Carew  Update publish_internal.yaml (dart-lang/ecosystem#345)
  25f0fb2  2025-03-04  Devon Carew  Update README.md (dart-lang/ecosystem#344)
  331d35d  2025-03-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/ecosystem#343)

i18n (https://github.com/dart-lang/i18n/compare/06a664f..bdeec25):
  bdeec25  2025-03-04  Moritz  Publish `package:intl4x: 0.11.0` (dart-lang/i18n#953)
  d84a927  2025-03-04  Moritz  Update publishing workflow
  547ce9f  2025-03-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/i18n#952)
  c6b911b  2025-02-21  dependabot[bot]  Bump the github-actions group across 1 directory with 4 updates (dart-lang/i18n#949)
  c3e9fe2  2025-02-21  Moritz  Update to new native_assets (dart-lang/i18n#941)

protobuf (https://github.com/dart-lang/protobuf/compare/610943a..7838e44):
  7838e44  2025-03-07  Ömer Sinan Ağacan  Prefix grpc method 'call' and 'request' arguments with '$' to avoid shadowing user methods with the same name (google/protobuf.dart#964)
  125fe9c  2025-03-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (google/protobuf.dart#965)
  fb77c7c  2025-03-02  dependabot[bot]  Bump actions/cache from 4.2.0 to 4.2.2 (google/protobuf.dart#966)

shelf (https://github.com/dart-lang/shelf/compare/b39e611..2af8529):
  2af8529  2025-03-04  Devon Carew  Update publish.yaml (dart-lang/shelf#473)
  f5ae797  2025-03-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/shelf#471)

sync_http (https://github.com/dart-lang/sync_http/compare/47e6b26..dc54465):
  dc54465  2025-03-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (google/sync_http.dart#54)

test (https://github.com/dart-lang/test/compare/a833663..9e349d0):
  9e349d0e  2025-03-06  Jonas Finnemann Jensen  Suggest using `dart pub add dev:checks` (dart-lang/test#2467)
  e941dbac  2025-03-04  Devon Carew  Update publish.yaml (dart-lang/test#2465)
  32bf9b73  2025-03-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/test#2462)

tools (https://github.com/dart-lang/tools/compare/b51f39d..d67cd00):
  d67cd002  2025-03-07  Parker Lougheed  [pub_semver] Remove dependency on `package:meta` (dart-lang/tools#2021)
  04667d7e  2025-03-06  Parker Lougheed  [pub_semver] Discourage modification of properties intended to be unmodifiable (dart-lang/tools#2020)
  b23129b9  2025-03-04  Devon Carew  Update publish.yaml (dart-lang/tools#2025)
  9765c2aa  2025-02-25  Parker Lougheed  [package_config] Implement relational operators for `LanguageVersion` (dart-lang/tools#2016)

vector_math (https://github.com/google/vector_math.dart/compare/533c513..f08d7d2):
  f08d7d2  2025-03-01  dependabot[bot]  Bump dart-lang/setup-dart in the github-actions group (google/vector_math.dart#340)

web (https://github.com/dart-lang/web/compare/c2d5f63..4854093):
  4854093  2025-03-04  Srujan Gaddam  Add pull request and id-token write permissions to publish.yaml (dart-lang/web#351)
  33ed133  2025-03-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/web#349)
  6031c1f  2025-02-26  Kevin Moore  Delete all deprecated members (dart-lang/web#347)
  5a39fdc  2025-02-26  Kevin Moore  Merge tag 'web-v1.1.1'
  222164b  2025-02-26  Kevin Moore  Deprecate a few more things before we launch v2 (dart-lang/web#348)
  b90b63d  2025-02-25  Kevin Moore  Update APIs and docs (dart-lang/web#345)
  5caa92e  2025-02-25  Srujan Gaddam  Add catch and finally to bannedNames (dart-lang/web#346)
  e2f9741  2025-02-25  Olzhas Suleimen  Add variadic arguments (dart-lang/web#343)

webdriver (https://github.com/google/webdriver.dart/compare/b4fd859..f52afbf):
  f52afbf  2025-03-06  Parker Lougheed  Utilize switch expressions (google/webdriver.dart#327)
  ee311e0  2025-03-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.7.0 to 1.7.1 (google/webdriver.dart#328)
  b0cb6a9  2025-02-27  Kevin Moore  Update to Dart/Flutter team lints and fix (google/webdriver.dart#322)
  d080ebf  2025-02-27  Kevin Moore  Update a number of APIs to return Uint8List (google/webdriver.dart#323)
  0400c06  2025-02-27  Kevin Moore  Re-enable Firefox on CI (google/webdriver.dart#324)
  38a6646  2025-02-24  Parker Lougheed  Minor cleanup for new and future lints (google/webdriver.dart#321)

Change-Id: Ied703b048f85dd78e30084ffa8bffcaab5bab67b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414301
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more than one variable arguments.
2 participants
@ykmnkmi @srujzs