-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updates for Dart 2.0 corelib changes (wave 2.2). #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the original websocket implementation in the SDK doesn't use StreamTransformerBase
. Should that get updated first?
The changes to websocket haven't changed yet. How about I leave this version sitting in a branch so that we can use it internally and in the SDK, and then once the changes land in the SDK we can abandon this and you can publish a new version using your process? |
Sounds fine. |
This was fixed by 0f37053. |
Restoring branch temporarily until I roll SDK deps. |
Oops, sorry about that! |
No problem, I didn't know this was an issue until it came up with async, and I meant to fix this up then, but didn't get around to it in time. Just sent you a CL to roll deps, then we should be able to delete. |
Changes code that
implements StreamTransformer
toextend StreamTransformerBase
.