Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates for Dart 2.0 corelib changes (wave 2.2). #11

Closed
wants to merge 2 commits into from

Conversation

leafpetersen
Copy link
Member

Changes code that implements StreamTransformer to extend StreamTransformerBase.

Copy link
Member

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the original websocket implementation in the SDK doesn't use StreamTransformerBase. Should that get updated first?

@leafpetersen
Copy link
Member Author

The changes to websocket haven't changed yet. How about I leave this version sitting in a branch so that we can use it internally and in the SDK, and then once the changes land in the SDK we can abandon this and you can publish a new version using your process?

@nex3
Copy link
Member

nex3 commented Feb 1, 2018

Sounds fine.

@nex3
Copy link
Member

nex3 commented Feb 14, 2018

This was fixed by 0f37053.

@nex3 nex3 closed this Feb 14, 2018
@nex3 nex3 deleted the corelib_2_2 branch February 14, 2018 20:18
@leafpetersen leafpetersen restored the corelib_2_2 branch February 14, 2018 20:28
@leafpetersen
Copy link
Member Author

Restoring branch temporarily until I roll SDK deps.

@nex3
Copy link
Member

nex3 commented Feb 14, 2018

Oops, sorry about that!

@leafpetersen
Copy link
Member Author

No problem, I didn't know this was an issue until it came up with async, and I meant to fix this up then, but didn't get around to it in time. Just sent you a CL to roll deps, then we should be able to delete.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants