Skip to content

remove a todo from the frontend_server_client readme #1617

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

devoncarew
Copy link
Member

  • remove a todo from the frontend_server_client readme
  • rev the pubspec version (some changes had landed here since the last publish)
  • add some std markdown badges to the readme

@jakemac53
Copy link
Contributor

Feel free to jump right to the next stable if we are going to publish immediately

@devoncarew
Copy link
Member Author

devoncarew commented May 16, 2022

Feel free to jump right to the next stable if we are going to publish immediately

I may land this as is as I'm not super familiar w/ the versioning process for this package. Specifically, I see This package keeps a relatively tight version constraint on the SDK to allow for breaking changes in the frontend_server binary itself in the readme, but I see that the pubspec has our std >=2.12 < 3.0 sdk constraint...

@devoncarew devoncarew merged commit 662970f into master May 16, 2022
@jakemac53
Copy link
Contributor

Specifically, I see This package keeps a relatively tight version constraint on the SDK to allow for breaking changes in the frontend_server binary itself. in the readme, but I see that the pubspec has our std >=2.12 < 3.0 sdk constraint...

I believe we just changed the policy here and that is probably an old comment

@jakemac53 jakemac53 deleted the remove_todo branch May 16, 2022 18:03
@jakemac53
Copy link
Contributor

Fwiw this package is now used in the SDK itself which is partially what makes it "safer" for us to widen it (at least we can release fixes early). If we drop it from the SDK, we would want to at least ensure we have some cron jobs or something set up to test against the raw SDK builds.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants