Skip to content

Prep to publish frontend-server-client #1618

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2022
Merged

Prep to publish frontend-server-client #1618

merged 2 commits into from
May 16, 2022

Conversation

annagrin
Copy link
Contributor

Closes: #1606

@annagrin annagrin requested review from devoncarew and jakemac53 May 16, 2022 18:04
jakemac53
jakemac53 reviewed May 16, 2022
View reviewed changes
devoncarew
devoncarew approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo Jake's question about the vm_service dep

@devoncarew
Copy link
Member

When this does land in master, there's now a handy tool to rev sdk deps; from the sdk repo:

dart tools/manage_deps.dart bump third_party/pkg/webdev

That'll rev to the latest dep and create a CL for you.

@annagrin annagrin merged commit c1d2237 into dart-lang:master May 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

publish package:frontend_server_client
3 participants
@annagrin @devoncarew @jakemac53