Skip to content

Fix failure to get source maps on windows with base change in index.html #1625

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented May 23, 2022

Use only forward slashes for server paths in FrontendServerRequireStrategy.

Server path should only contain forward slashes, but p.join() added backward slashes on windows when prepending a base path to the server path. This caused dwds to use incorrect source map paths and a failures to set breakpoints.

Changes:

  • use string concatenation instead of p.join in FrontendServerRequireStrategy.
  • Add breakpoint and evaluation tests for non-trivial bases.
  • Move out shared code for evaluation tests for various compilation modes.

Closes: #1624
Helps: flutter/flutter-intellij#6159

@annagrin annagrin requested review from elliette and grouma May 24, 2022 01:19
@annagrin annagrin merged commit ceb47bc into dart-lang:master May 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VM service addBreakpointWithScriptUri sometimes failing for web on Windows
2 participants