Skip to content

Send a kPausePostRequest after restarting to notify clients to resume #2441

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 29, 2024

Conversation

elliette
Copy link
Contributor

Fixes dart-lang/sdk#55860

DAP is waiting for a kPausePostRequest after restarting to know to resume the isolate. DWDS was never sending this event, so the app was never resumed: https://github.com/dart-lang/sdk/blob/6549a66a50c7a732e51df68322c604936057ecea/pkg/dds/lib/src/dap/isolate_manager.dart#L644

@elliette elliette requested a review from helin24 May 29, 2024 18:13
@elliette elliette merged commit 7eeebbb into dart-lang:master May 29, 2024
47 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DAP] --pause-isolates-on-start flag is not respected for web refreshes
2 participants