Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CMake: Add DART_SKIP_<dep> advanced options #1497

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

traversaro
Copy link
Contributor

Add DART_SKIP_ option to permit to specify that a dependency should not used even if it is found in the system.

This is useful in package managers such as vcpkg to ensure that, for a given set of enabled features, the same version of the library is build, independently from which dependency are actually installed in the system. A mpre extended rationale is provided in gazebosim/gz-cmake#63 .

Add DART_SKIP_<dep> option to permit to specify that
a dependecy should not used even if it is found in the system.
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1497 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1497   +/-   ##
=======================================
  Coverage   58.17%   58.17%           
=======================================
  Files         414      414           
  Lines       30008    30008           
=======================================
  Hits        17456    17456           
  Misses      12552    12552           

@jslee02
Copy link
Member

jslee02 commented Sep 16, 2020

We had a similar discussion in #1056 that is to control which component to be built (using CMake option like DART_BUILD_<component>). In this way, we could disable the components that require the dependencies you want to skip. Do you think it would also have the same effect?

@traversaro
Copy link
Contributor Author

We had a similar discussion in #1056 that is to control which component to be built (using CMake option like DART_BUILD_<component>). In this way, we could disable the components that require the dependencies you want to skip. Do you think it would also have the same effect?

I think that could also be used in that context.

@traversaro
Copy link
Contributor Author

Hi @jslee02, so do you prefer that I close this PR and I open implementing what was discussed in #1056 ?

@jslee02
Copy link
Member

jslee02 commented Oct 25, 2020

@traversaro Yeah, but let me create a PR based on the discussion in #1056 as I already started it if it sounds good to you as well.

@traversaro
Copy link
Contributor Author

Perfect, thanks!

@jslee02
Copy link
Member

jslee02 commented Apr 4, 2021

Merging this PR resolves the described issue without hurting the current build system. Will revisit to consider method discussed in #1056 if needed

@jslee02 jslee02 merged commit a7584a1 into dartsim:master Apr 4, 2021
@jslee02 jslee02 added this to the DART 6.10.0 milestone Apr 4, 2021
@traversaro
Copy link
Contributor Author

Thanks @jslee02 !

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants