Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: relax dask version requirement and use a better check for Task #563

Merged
merged 10 commits into from
Dec 17, 2024

Conversation

lgray
Copy link
Collaborator

@lgray lgray commented Dec 17, 2024

@martindurant we got pretty... erm direct... feedback that backwards compatibility would be appreciated.

Also the current check was not working with very recent, but older, dask that has Task but it isn't used in blockwise.

@martindurant
Copy link
Collaborator

We are accepting more future work by allowing for earlier dask. That must be recognised.

@lgray
Copy link
Collaborator Author

lgray commented Dec 17, 2024

It's less future work w.r.t. people managing clusters and images. There are all sorts of weird regressions from dask version to dask version, their pinning times are much longer than ours.

@lgray
Copy link
Collaborator Author

lgray commented Dec 17, 2024

@martindurant changing things so that we avoid touching the private module _task_spec and grab Task/TaskRef/GraphNode from blockwise. The latter is far less likely to disappear or move, and the naming of the classes is probably pretty stable.

@lgray
Copy link
Collaborator Author

lgray commented Dec 17, 2024

any further commentary on this one?

@lgray lgray merged commit 6150c5d into main Dec 17, 2024
25 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants