Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update autotag to cover more versions #192

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

jakirkham
Copy link
Member

Changes the README to use reference links for easier version replacement. Updates the regex in the autotag to cover versions in more files.

Breaks out the image links to make them easier to update. Also should
aid regex version matching.
Should allow auto-updating of versions in the README and GitHub
workflows.
@@ -15,5 +15,4 @@ jobs:
with:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
strategy: regex
root: ".github/workflows/build.yml"
regex_pattern: '\s*release\s*:\s*"([\d\.]+)"\s*'
regex_pattern: '\s*\[?.*release\]?: "?.*(\d{4}\.\d{1,2}\.\d+).*"?'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From running locally

$ grep -E '\s*\[?.*release\]?: "?.*(\d{4}\.\d{1,2}\.\d+).*"?' $(find . -not -path "./.git/*" -type f)
./README.md:[daskdev-dask-release]: https://img.shields.io/badge/daskdev%2Fdask-2021.10.0-blue
./README.md:[daskdev-dask-py38-release]: https://img.shields.io/badge/daskdev%2Fdask-2021.10.0--py3.8-blue
./README.md:[daskdev-dask-py39-release]: https://img.shields.io/badge/daskdev%2Fdask-2021.10.0--py3.9-blue
./README.md:[daskdev-dask-notebook-release]: https://img.shields.io/badge/daskdev%2Fdask--notebook-2021.10.0-blue
./README.md:[daskdev-dask-notebook-py38-release]: https://img.shields.io/badge/daskdev%2Fdask--notebook-2021.10.0--py3.8-blue
./README.md:[daskdev-dask-notebook-py39-release]: https://img.shields.io/badge/daskdev%2Fdask--notebook-2021.10.0--py3.9-blue
./.github/workflows/build.yml:      release: "2021.10.0"
./build/docker-compose.yml:        release: "2021.10.0"
./build/docker-compose.yml:        release: "2021.10.0"
./build/docker-compose.yml:        release: "2021.10.0"

@jakirkham
Copy link
Member Author

cc @jrbourbeau (for awareness)

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @jakirkham

@jacobtomlinson jacobtomlinson merged commit b05e211 into dask:main Oct 25, 2021
@jakirkham jakirkham deleted the tmplt_more_ver branch October 25, 2021 16:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants