Skip to content

Remove functionality of batching submission in client.map #8771

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Jul 16, 2024

With the HLG layer this batching is now actually harmful since pretty much the exact same object is resubmitted over and over again

@fjetter fjetter marked this pull request as draft July 16, 2024 12:37
Copy link
Contributor

github-actions bot commented Jul 16, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ± 0      29 suites  ±0   11h 58m 18s ⏱️ - 5m 55s
 4 087 tests + 3   3 971 ✅ + 9    112 💤 ±0  4 ❌  - 6 
55 286 runs  +42  52 842 ✅ +45  2 439 💤 +4  5 ❌  - 7 

For more details on these failures, see this check.

Results for commit a04a25f. ± Comparison against base commit ea46f72.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released_when_worker_removed[False]
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released_when_worker_removed[True]
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released_when_worker_replaced[False]
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released_when_worker_replaced[True]

♻️ This comment has been updated with latest results.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant