Skip to content

Raise explicit pickle errors when distributed.pickle.{loads|dumps} fails #8888

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Raise explicit pickle errors when distributed.pickle.{loads|dumps} fails #8888

wants to merge 3 commits into from

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented Oct 10, 2024 •
edited
Loading

Supersedes #8882

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait marked this pull request as draft October 10, 2024 18:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ± 0      25 suites  ±0   10h 19m 17s ⏱️ - 5m 24s
 4 131 tests + 1   4 015 ✅  - 1    110 💤 ±0   6 ❌ + 2 
47 720 runs  +12  45 606 ✅  - 3  2 095 💤 ±0  19 ❌ +15 

For more details on these failures, see this check.

Results for commit 53f0039. ± Comparison against base commit ecee9e8.

♻️ This comment has been updated with latest results.

@hendrikmakait hendrikmakait marked this pull request as ready for review October 11, 2024 05:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@phofl phofl phofl approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hendrikmakait @phofl