Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update Dockerfile #45

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Update Dockerfile #45

merged 1 commit into from
Jan 19, 2024

Conversation

mickdekkers
Copy link
Contributor

@mickdekkers mickdekkers commented Jan 18, 2024 •
edited by coderabbitai bot
Loading

Changes

  • Update to non-deprecated base image version
  • Preinstall deepspeed in Docker image so this isn't done each time the app is run
  • Optimize Docker layer caching by installing xtts-api-server after torch & torchaudio (which likely change less frequently)
  • Listen on all network interfaces, ensuring the server is reachable from the host machine
  • Set the tunnel URL argument in the Docker CMD to localhost so the preview_urls returned by /speakers are accessible from the host machine

Summary by CodeRabbit

  • New Features

    • Upgraded to a newer CUDA version for enhanced performance.
    • Integrated DeepSpeed for optimized model training.

  • Refactor

    • Updated the server command to improve API responsiveness and consistency.

@mickdekkers
Update Dockerfile
ff1dced 
- Update to non-deprecated base image version
- Preinstall deepspeed in Docker image so this isn't done each time the app is run
- Optimize Docker layer caching by installing xtts-api-server after torch & torchaudio (which likely change less frequently)
- Listen on all network interfaces, ensuring the server is reachable from the host machine
- Set the tunnel URL argument in the Docker CMD to localhost so the preview_urls returned by /speakers are accessible from the host machine
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2024 •
edited
Loading

Walkthrough

The Dockerfile has been updated to use a newer CUDA base image, added the installation of DeepSpeed alongside the xtts-api-server, and modified the command to run the server. The changes suggest a focus on enhancing the server's capabilities with DeepSpeed optimization and potentially updating compatibility with the newer CUDA version.

Changes

File Change Summary
docker/Dockerfile Updated base image from nvidia/cuda:12.1.0-cudnn8-devel-ubuntu22.04 to nvidia/cuda:12.1.1-cudnn8-devel-ubuntu22.04
docker/Dockerfile Added installation of deepspeed before xtts-api-server
docker/Dockerfile Updated CMD to include --listen flag and changed host specification to http://localhost:8020

🐇✨

In Docker's realm, a change was made,

With CUDA fresh, the base was laid.

Deepspeed hops in, with XTTS in tune,

A rabbit's delight, under tech's moon. 🌙

🚀🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c9b46be and ff1dced.
Files selected for processing (1)
  • docker/Dockerfile (2 hunks)
Additional comments: 3
docker/Dockerfile (3)
  • 2-2: Updated base image to nvidia/cuda:12.1.1-cudnn8-devel-ubuntu22.04.

This change aligns with the NVIDIA container images support policy and is a good practice for maintaining up-to-date dependencies.

  • 23-24: Installation of deepspeed before xtts-api-server.

This change is beneficial for Docker layer caching, as deepspeed is less likely to change than the application code, allowing for more efficient use of the cache.

  • 30-30: Modification of the CMD instruction to include --listen and set the tunnel URL to http://localhost:8020.

This change ensures that the server listens on all network interfaces and that the preview_urls are accessible from the host machine, which is important for development and testing.

@daswer123
Copy link
Owner

Hi, thanks for your work, I'm not really good at docker )

@daswer123 daswer123 merged commit 8a298b6 into daswer123:main Jan 19, 2024
@mickdekkers
Copy link
Contributor Author

Thanks for building this project! Happy to help :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickdekkers @daswer123