This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinheidegger
previously requested changes
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the layout issues first.
#600 (comment) |
AtuyL
force-pushed
the
fix/overlay-on-menu-open
branch
from
November 23, 2018 01:10
b874afd
to
f80856c
Compare
AtuyL
force-pushed
the
fix/overlay-on-menu-open
branch
from
November 23, 2018 01:11
f80856c
to
0c85c3c
Compare
@martinheidegger san |
AtuyL
force-pushed
the
fix/overlay-on-menu-open
branch
from
November 29, 2018 01:29
0c85c3c
to
32d3814
Compare
AtuyL
force-pushed
the
fix/overlay-on-menu-open
branch
from
November 30, 2018 05:20
32d3814
to
5d05d27
Compare
martinheidegger
approved these changes
Nov 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making it work with the z-index. I know its a bit of a hacky solution. Lets make it cleaner in future version.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR for to-re-working the overlay on menu-open.