Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue with repeat() #66

Merged
merged 1 commit into from
Oct 15, 2024
+9 −3
Merged

Fix issue with repeat() #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions array_api_strict/_manipulation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

from ._array_object import Array
from ._creation_functions import asarray
from ._data_type_functions import result_type
from ._dtypes import _integer_dtypes
from ._data_type_functions import astype, result_type
from ._dtypes import _integer_dtypes, int64, uint64
from ._flags import requires_api_version, get_array_api_strict_flags

from typing import TYPE_CHECKING
Expand Down Expand Up @@ -94,7 +94,13 @@ def repeat(
else:
raise TypeError("repeats must be an int or array")

return Array._new(np.repeat(x._array, repeats, axis=axis))
if repeats.dtype == uint64:
# NumPy does not allow uint64 because can't be cast down to x.dtype
# with 'safe' casting. However, repeats values larger than 2**63 are
# infeasable, and even if they are present by mistake, this will
# lead to underflow and an error.
repeats = astype(repeats, int64)
return Array._new(np.repeat(x._array, repeats._array, axis=axis))

# Note: the optional argument is called 'shape', not 'newshape'
def reshape(x: Array,
Expand Down
Loading